Add eslint config to prevent introduction of non-erasable changes

Author: brendandburns

eslint.config.js

@@ -1,11 +1,13 @@
 import eslint from '@eslint/js';
+import erasableSyntaxOnly from 'eslint-plugin-erasable-syntax-only';
 import tseslint from 'typescript-eslint';
 
 export default tseslint.config(
     {
         ignores: ['dist/', 'docs/', 'node_modules/', 'src/gen/'],
     },
     eslint.configs.recommended,
+    erasableSyntaxOnly.configs.recommended,
     tseslint.configs.strict,
     {
         languageOptions: {

package-lock.json

@@ -80,6 +80,7 @@
         "@types/mock-fs": "^4.13.1",
         "c8": "^10.0.0",
         "eslint": "^9.18.0",
+        "eslint-plugin-erasable-syntax-only": "^0.3.0",
         "husky": "^9.0.6",
         "mocha": "^11.0.1",
         "mock-fs": "^5.2.0",

package.json

@@ -36,8 +36,10 @@ describe('KubernetesObject', () => {
     });
 
     class KubernetesObjectApiTest extends KubernetesObjectApi {
-        constructor(public configuration: Configuration) {
+        public configuration: Configuration;
+        public constructor(configuration: Configuration) {
             super(configuration);
+            this.configuration = configuration;
         }
 
         public static makeApiClient(kc?: KubeConfig): KubernetesObjectApiTest {

src/object_test.ts

@@ -7,11 +7,12 @@ export function matchBuffer(channel: number, contents: string): StringBufferMatc
 }
 
 class StringBufferMatcher extends Matcher {
-    constructor(
-        private channel: number,
-        private contents: string,
-    ) {
+    private channel: number;
+    private contents: string;
+    constructor(channel: number, contents: string) {
         super();
+        this.channel = channel;
+        this.contents = contents;
     }
 
     public valueOf(): string {