Fixed issue in LinkedList insert(_:, at:) method where next?.previous… #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… was referencing next itself.
kelvinlauKL
approved these changes
Jun 11, 2018
|
Looks good. After the CI finishes running, I'll merge it in. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… was referencing next itself.
Checklist
Description
Small fix in the insert(_ list: LinkedList, at index: Int) method of the LinkedList class.
In the LinkedList Swift file (line 169) and the Playground page (line 179), the previous property of the next node was being set to the next node itself, instead of the inserted list's last node.