fix e2e workflows and fix linter

Author: dprotaso

.github/workflows/kind-e2e.yaml

@@ -11,8 +11,8 @@ jobs:
       fail-fast: false # Keep running if one leg fails.
       matrix:
         k8s-version:
-        - v1.31.x
         - v1.32.x
+        - v1.33.x
         ingress:
         - istio
         - contour

.golangci.yaml

@@ -141,6 +141,10 @@ linters:
   disable:
     - errcheck
   settings:
+    staticcheck:
+      checks:
+      - all
+      - "-QF1008" # Disable https://staticcheck.dev/docs/checks/#QF1008
     gocritic:
       disabled-checks:
         - exitAfterDefer
@@ -178,6 +182,9 @@ linters:
       - legacy
       - std-error-handling
     rules:
+      - linters:
+          - staticcheck
+        text: v1.Endpoint.* is deprecated
       - linters:
           - gosec
           - noctx

pkg/reconciler/ingress/lister.go

@@ -107,7 +107,7 @@ func (l *gatewayPodTargetLister) BackendsToProbeTargets(ctx context.Context, bac
 		} else {
 			gw, err := l.gatewayLister.Gateways(gateway.Namespace).Get(gateway.Name)
 			if apierrs.IsNotFound(err) {
-				return nil, fmt.Errorf("Gateway %q does not exist: %w", gateway, err) //nolint:stylecheck
+				return nil, fmt.Errorf("Gateway %q does not exist: %w", gateway, err) //nolint:staticcheck
 			} else if err != nil {
 				return nil, err
 			}

pkg/reconciler/ingress/reconcile_resources.go

@@ -316,7 +316,7 @@ func (c *Reconciler) reconcileGatewayListeners(
 	gw, err := c.gatewayLister.Gateways(gwName.Namespace).Get(gwName.Name)
 	if apierrs.IsNotFound(err) {
 		recorder.Eventf(ing, corev1.EventTypeWarning, "GatewayMissing", "Unable to update Gateway %s", gwName.String())
-		return fmt.Errorf("Gateway %s does not exist: %w", gwName, err) //nolint:stylecheck
+		return fmt.Errorf("Gateway %s does not exist: %w", gwName, err) //nolint:staticcheck
 	} else if err != nil {
 		return err
 	}

pkg/reconciler/testing/factory.go

@@ -70,7 +70,7 @@ func MakeFactory(ctor Ctor) rtesting.Factory {
 		// Set up our Controller from the fakes.
 		c := ctor(ctx, &ls, configmap.NewStaticWatcher())
 		// Update the context with the stuff we decorated it with.
-		r.Ctx = ctx //nolint:fatcontext
+		r.Ctx = ctx
 
 		// The Reconciler won't do any work until it becomes the leader.
 		if la, ok := c.(reconciler.LeaderAware); ok {