[Autocomplete-Select] Keep all data in options, and allow to retrieve them in onChange

[rodolpheV]

Current behaviour

The autocomplete select component only keep label and value properties in its options:
edit.js#L153: data.forEach(item => { options.set(item[keyName], item[labelName]); });
And only the key is given to the onChange:
edit.js#L210: onChange(key)

As others data properties are only in the store used by the querySearcher, the view has to directly get them here if needed.

Expected behaviour

Keep all data in options: this.setState({options: data}), or keep them duplicated in data: this.setState({data})
And allow to retrieve them in onChange: onChange(key, option)

Versions

Focus-core: 2.1.1
Focus-components: 2.1.7-1

[Hartorn]

@rodolpheV I won't add a second argument on onChange function.
For input, onChange should take only the value on entry.
Eventually, we could have an option to get the whole value instead of the key.

But before that, for your problem, I don't see any use case. Could you elaborate a bit more ?

[rodolpheV]

Then I'll explain my use of this component:
I have a component that uses the AutocompleteSelect to get a unit:

<AutocompleteSelect
   querySearcher={this.searchUnit}
   onChange={this.onUnitOptionClick}
   keyName='unitId'
   labelName='value'
/>

The method onUnitOptionClick passed as onChange to the AutocompleteSelect:

onUnitOptionClick(unitId) {
    const storeUnitList = planStore.searchUnit();
    const unit = storeUnitList.find(u => u.unitId === unitId);
    return this.addUnitToSelection(unit);
},

And I would like to do:

onUnitOptionClick(unitId, unit) {
    return this.addUnitToSelection(unit);
},

[Hartorn]

I guess we can add on option wholeValue, and in onChange, return the whole value instead of the id in this case.

[Hartorn]

@c3dr0x I let you do that one :)