HTML games don't work on Firefox 142.0.1 Windows since version 2.5.0

[jsmonzani]

Since version 2.5.0 (and currently 2.5.4), games won't launch properly on Firefox 142.0.1 (latest) on Windows.
They work on Chrome.

For instance, when launching the "hello" example https://kitao.github.io/pyxel/wasm/examples/01-hello-pyxel.html
I get:

• the Pyxel logo
• then "Touch to start"
• then nothing happens.

Console logs are:
Launch Pyxel 2.5.4 with Pyodide 0.27.7
Object { command: "run", root: "../../python/pyxel/examples", name: "01_hello_pyxel.py", script: undefined, packages: undefined, gamepad: undefined }
Loading pyxel
Loaded pyxel

I've tried running the example with a local web server with the same issue.
Changing the HTML source and using @2.4.10 instead of @latest solves the issue.

[kitao]

I've test Firefox on Mac and it worked.
The console log is also correct message.
I'll continue investigation with Windows machine.

[kitao]

@jsmonzani
I installed the latest Firefox on Windows and Pyxel examples worked.
Could you try again after removing browser cache?

[jsmonzani]

@kitao I've tested on two other computers with the same issue.
However I think I know what's going on. When launching, it writes
TOUCH to start
and not
CLICK to start.
Which means it wrongly detects mobile mode on desktop.
So if I click with my mouse, nothing happens.
However, if I emulate mobile mode in Firefox desktop and send a touch event instead of mouse click, then the game starts.

On a sidenote, I confirm that Chrome writes CLICK to start.

[merwok]

I’ll note that this wrong detection happens to me with many sites: asana, google drive…

I use Firefox LTS (128.14.0 currently) and sites / browser detection libraries don’t seem to handle it correctly. Other sites don’t detect features correctly (like slack blocking video calls that could work).

[jsmonzani]

I see! Maybe in pyxel.js line 445

await _waitForEvent(document.body, _isTouchDevice() ? "touchstart" : "click");

could be changed to accept click events even when isTouchedDevice is detected?

[kitao]

OK. I'll change to check the both events.