Skip to content

Commit f3cebd4

Browse files
rostedtKernel Patches Daemon
authored andcommitted
xdp: Remove unused mem_return_failed event
The change to allow page_poll to handle its own page destruction instead of relying on XDP removed the trace_mem_return_failed() tracepoint caller, but did not remove the mem_return_failed trace event. As trace events take up memory when they are created regardless of if they are used or not, having this unused event around wastes around 5K of memory. Remove the unused event. Link: https://lore.kernel.org/all/[email protected]/ Fixes: c3f812c ("page_pool: do not release pool until inflight == 0.") Signed-off-by: Steven Rostedt (Google) <[email protected]> Acked-by: Jesper Dangaard Brouer <[email protected]> Acked-by: Jakub Kicinski <[email protected]>
1 parent 810d3c3 commit f3cebd4

File tree

1 file changed

+0
-26
lines changed
  • include/trace/events

1 file changed

+0
-26
lines changed

include/trace/events/xdp.h

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -379,32 +379,6 @@ TRACE_EVENT(mem_connect,
379379
)
380380
);
381381

382-
TRACE_EVENT(mem_return_failed,
383-
384-
TP_PROTO(const struct xdp_mem_info *mem,
385-
const struct page *page),
386-
387-
TP_ARGS(mem, page),
388-
389-
TP_STRUCT__entry(
390-
__field(const struct page *, page)
391-
__field(u32, mem_id)
392-
__field(u32, mem_type)
393-
),
394-
395-
TP_fast_assign(
396-
__entry->page = page;
397-
__entry->mem_id = mem->id;
398-
__entry->mem_type = mem->type;
399-
),
400-
401-
TP_printk("mem_id=%d mem_type=%s page=%p",
402-
__entry->mem_id,
403-
__print_symbolic(__entry->mem_type, __MEM_TYPE_SYM_TAB),
404-
__entry->page
405-
)
406-
);
407-
408382
TRACE_EVENT(bpf_xdp_link_attach_failed,
409383

410384
TP_PROTO(const char *msg),

0 commit comments

Comments
 (0)