Fixed Issues from clang-tidy (#13)

* Fixed static analysis checks in the CI

* Ignoring trailing return type warning

* Fixed multi-line CI

* Ignoring the "fuchsia-overloaded-operator"

* Header guard follows the llvm style

* Added [[maybe_unused]] for the main

* Ignoring pointer arithmetic warning in a specific case

* Remove EOL

* Removed EOL

Author: karel-burda

.github/workflows/main.yml

@@ -14,10 +14,14 @@ jobs:
       - uses: actions/checkout@v3
 
       - name: g++
-        run: g++ --version && g++ main.cpp -I include -std=c++17 -O2 -Wall -Wextra -pedantic -Wshadow -Werror
+        run: |
+             g++ --version && \
+             g++ main.cpp -I include -std=c++17 -O2 -Wall -Wextra -pedantic -Wshadow -Werror
 
       - name: clang++
-        run: clang++ --version && clang++ main.cpp -I include -std=c++17 -O2 -Wall -Wextra -pedantic -Wshadow -Werror
+        run: |
+             clang++ --version && \
+             clang++ main.cpp -I include -std=c++17 -O2 -Wall -Wextra -pedantic -Wshadow -Werror
 
   static_analysis:
     runs-on: ubuntu-latest
@@ -26,7 +30,9 @@ jobs:
       - uses: actions/checkout@v3
 
       - name: clang-tidy
-        run: clang-tidy --version && clang-tidy -warnings-as-errors -checks="*" main.cpp -- -I include -std=c++17
+        run: |
+             clang-tidy --version && \
+             clang-tidy include/constexpr_hash_map/constexpr_hash_map.hpp main.cpp --checks="*,-llvmlibc-*,-modernize-use-trailing-return-type" --warnings-as-errors="*" -- -I include -std=c++17
 
   documentation:
     runs-on: ubuntu-latest

include/constexpr_hash_map/constexpr_hash_map.hpp

@@ -1,5 +1,5 @@
-#ifndef BURDA_CONSTEXPR_HASH_MAP_HPP
-#define BURDA_CONSTEXPR_HASH_MAP_HPP
+#ifndef CONSTEXPR_HASH_MAP_CONSTEXPR_HASH_MAP_HPP
+#define CONSTEXPR_HASH_MAP_CONSTEXPR_HASH_MAP_HPP
 
 #include <array>
 #include <cstddef>
@@ -71,6 +71,7 @@ class hash_map
     ///        Doesn't perform any bounds checking, behaviour is undefined if the key doesn't exist
     /// @param key key to be searched for
     /// @return reference to constant to a value associated with the key
+    // NOLINTNEXTLINE(fuchsia-overloaded-operator)
     [[nodiscard]] constexpr const V& operator[](const K& key) const noexcept
     {
         return find(key)->second;
@@ -162,6 +163,7 @@ class hash_map
     /// @private specific implementation for "const char*" equality is needed; uses recursion
     [[nodiscard]] constexpr bool equal(const char* lhs, const char* rhs) const noexcept
     {
+        // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic)
         return *lhs == *rhs && (*lhs == '\0' || equal(lhs + 1, rhs + 1));
     }
 
@@ -170,4 +172,4 @@ class hash_map
 };
 }  // namespace burda::ct
 
-#endif // BURDA_CONSTEXPR_HASH_MAP_HPP
+#endif // CONSTEXPR_HASH_MAP_CONSTEXPR_HASH_MAP_HPP

main.cpp

@@ -49,7 +49,7 @@ int example_advanced() noexcept
     return it->second.size();
 }
 
-int main(const int, const char**)
+int main([[maybe_unused]] const int argc, [[maybe_unused]] const char** argv)
 {
     return example_simple() + example_advanced();
-}
+}