Skip to content

Commit 63b3d44

Browse files
Leshe4kaLeshe4ka
and
Leshe4ka
authored
FE: UX: Fix multiple cluster menu selected (#1120)
Co-authored-by: Leshe4ka <[email protected]>
1 parent cd93135 commit 63b3d44

File tree

2 files changed

+10
-16
lines changed

2 files changed

+10
-16
lines changed

frontend/src/components/Nav/ClusterMenu/ClusterMenu.tsx

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,13 @@ import MenuTab from 'components/Nav/Menu/MenuTab';
55
import MenuItem from 'components/Nav/Menu/MenuItem';
66
import {
77
clusterACLPath,
8-
clusterAclRelativePath,
9-
clusterBrokerRelativePath,
8+
clusterBrokerPath,
109
clusterBrokersPath,
1110
clusterConnectorsPath,
12-
clusterConnectorsRelativePath,
1311
clusterConsumerGroupsPath,
14-
clusterConsumerGroupsRelativePath,
1512
clusterKsqlDbPath,
16-
clusterKsqlDbRelativePath,
1713
clusterSchemasPath,
18-
clusterSchemasRelativePath,
1914
clusterTopicsPath,
20-
clusterTopicsRelativePath,
2115
} from 'lib/paths';
2216
import { useLocation } from 'react-router-dom';
2317
import { useLocalStorage } from 'lib/hooks/useLocalStorage';
@@ -60,45 +54,45 @@ const ClusterMenu: FC<ClusterMenuProps> = ({
6054
{isOpen && (
6155
<S.List>
6256
<MenuItem
63-
isActive={getIsMenuItemActive(clusterBrokerRelativePath)}
57+
isActive={getIsMenuItemActive(clusterBrokerPath(name))}
6458
to={clusterBrokersPath(name)}
6559
title="Brokers"
6660
/>
6761
<MenuItem
68-
isActive={getIsMenuItemActive(clusterTopicsRelativePath)}
62+
isActive={getIsMenuItemActive(clusterTopicsPath(name))}
6963
to={clusterTopicsPath(name)}
7064
title="Topics"
7165
/>
7266
<MenuItem
73-
isActive={getIsMenuItemActive(clusterConsumerGroupsRelativePath)}
67+
isActive={getIsMenuItemActive(clusterConsumerGroupsPath(name))}
7468
to={clusterConsumerGroupsPath(name)}
7569
title="Consumers"
7670
/>
7771
{hasFeatureConfigured(ClusterFeaturesEnum.SCHEMA_REGISTRY) && (
7872
<MenuItem
79-
isActive={getIsMenuItemActive(clusterSchemasRelativePath)}
73+
isActive={getIsMenuItemActive(clusterSchemasPath(name))}
8074
to={clusterSchemasPath(name)}
8175
title="Schema Registry"
8276
/>
8377
)}
8478
{hasFeatureConfigured(ClusterFeaturesEnum.KAFKA_CONNECT) && (
8579
<MenuItem
86-
isActive={getIsMenuItemActive(clusterConnectorsRelativePath)}
80+
isActive={getIsMenuItemActive(clusterConnectorsPath(name))}
8781
to={clusterConnectorsPath(name)}
8882
title="Kafka Connect"
8983
/>
9084
)}
9185
{hasFeatureConfigured(ClusterFeaturesEnum.KSQL_DB) && (
9286
<MenuItem
93-
isActive={getIsMenuItemActive(clusterKsqlDbRelativePath)}
87+
isActive={getIsMenuItemActive(clusterKsqlDbPath(name))}
9488
to={clusterKsqlDbPath(name)}
9589
title="KSQL DB"
9690
/>
9791
)}
9892
{(hasFeatureConfigured(ClusterFeaturesEnum.KAFKA_ACL_VIEW) ||
9993
hasFeatureConfigured(ClusterFeaturesEnum.KAFKA_ACL_EDIT)) && (
10094
<MenuItem
101-
isActive={getIsMenuItemActive(clusterAclRelativePath)}
95+
isActive={getIsMenuItemActive(clusterACLPath(name))}
10296
to={clusterACLPath(name)}
10397
title="ACL"
10498
/>

frontend/src/components/Nav/Nav.styled.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ export const ClusterList = styled.ul.attrs<{ $colorKey: ClusterColorKey }>({
1515
role: 'menu',
1616
})`
1717
border-radius: 8px;
18-
padding: 4px 4px 4px 4px;
19-
margin-bottom: -8px;
18+
padding: 2px 4px;
19+
margin-bottom: 2px;
2020
background-color: ${({ theme, $colorKey }) =>
2121
theme.clusterMenu.backgroundColor[$colorKey]};
2222
`;

0 commit comments

Comments
 (0)