Skip to content

Commit ffebbaf

Browse files
vegetablestsaf
andauthored
Check kernel id before delete and upgrade ws (#1376)
Co-authored-by: saf <[email protected]>
1 parent d01e84a commit ffebbaf

File tree

1 file changed

+18
-0
lines changed

1 file changed

+18
-0
lines changed

enterprise_gateway/services/kernels/handlers.py

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,24 @@ def get(self, kernel_id: str):
146146
model = km.kernel_model(kernel_id)
147147
self.finish(json.dumps(model, default=date_default))
148148

149+
@web.authenticated
150+
async def delete(self, kernel_id):
151+
"""Remove a kernel."""
152+
self.kernel_manager.check_kernel_id(kernel_id=kernel_id)
153+
await super().delete(kernel_id=kernel_id)
154+
155+
156+
class ZMQChannelsHandler(
157+
TokenAuthorizationMixin, CORSMixin, JSONErrorsMixin, jupyter_server_handlers.ZMQChannelsHandler
158+
):
159+
"""Extends the kernel websocket handler."""
160+
161+
async def get(self, kernel_id):
162+
"""Handle a get request for a kernel."""
163+
# Synchronize Kernel and check if it exists.
164+
self.kernel_manager.check_kernel_id(kernel_id=kernel_id)
165+
await super().get(kernel_id=kernel_id)
166+
149167

150168
default_handlers: list[tuple] = []
151169
for path, cls in jupyter_server_handlers.default_handlers:

0 commit comments

Comments
 (0)