Skip to content

Commit 7302d9d

Browse files
committed
Update exit-status fixmes after (emacs-eask#307)
1 parent 5246888 commit 7302d9d

File tree

4 files changed

+10
-17
lines changed

4 files changed

+10
-17
lines changed

test/exit-status/compile/run.sh

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,10 @@ set -e
2424
source ./test/fixtures/home/scripts/testing.sh
2525
cd $(dirname "$0")
2626

27-
# FIXME this should match other commands which exit with status 1
2827
# partial input errors when there are no files
29-
# cd empty
30-
# should_error eask compile
31-
# cd ../
28+
cd empty
29+
should_error eask compile
30+
cd ../
3231

3332
# compiles with a warning
3433
should_run eask compile mock.el

test/exit-status/link/run.sh

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@ cd $(dirname "$0")
2727
# partial input
2828
should_error eask link
2929
should_error eask link add
30-
# FIXME should error
31-
# should_error eask link delete
30+
should_error eask link delete
3231

3332
# FIXME stack trace when package name doesn't match link name
3433
# prefer a better warning if this is important
@@ -44,8 +43,7 @@ OUTPUT="$(should_run eask link list)"
4443
echo "$OUTPUT"
4544
should_match "valid-package" "$OUTPUT"
4645

47-
# when package/link doesn't exist
48-
# FIXME: doesn't error
46+
# FIXME when package/link doesn't exist
4947
# should_error eask link delete foo
5048

5149
# no package after delete

test/exit-status/run/run.sh

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,9 @@ cd $(dirname "$0")
2727
should_error eask run
2828
# FIXME
2929
# should_error eask run command
30-
# FIXME
31-
# cd ./no-scripts/
32-
# should_error eask run script
33-
# cd ../
30+
cd ./no-scripts/
31+
should_error eask run script
32+
cd ../
3433

3534
should_run eask run command my-command my-warn
3635
# FIXME

test/exit-status/test/run.sh

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@ cd $(dirname "$0")
2828
# partial input
2929
should_error eask test
3030

31-
# FIXME
32-
# should_error eask test ert
33-
3431
echo "activate"
3532
echo "----------"
3633
cd ./activate/
@@ -74,8 +71,8 @@ should_error eask test ert-runner # all tests
7471

7572
echo "ert"
7673
echo "----------"
77-
# FIXME partial input should error
78-
# should_error eask test ert
74+
# partial input should error
75+
should_error eask test ert
7976

8077
should_run eask test ert test/ert-test.el
8178
should_error eask test ert test/ert-fail-test.el

0 commit comments

Comments
 (0)