rename redisconn.Opts.Async=>AsyncDial

Author: funny-falcon

example_test.go

@@ -26,7 +26,7 @@ func Example_usage() {
 			Logger:   redisconn.NoopLogger{}, // shut up logging. Could be your custom implementation.
 			Handle:   myhandle,               // custom data, useful for custom logging
 			// Other parameters (usually, no need to change)
-			// IOTimeout, DialTimeout, ReconnectTimeout, TCPKeepAlive, Concurrency, WritePause, Async
+			// IOTimeout, DialTimeout, ReconnectTimeout, TCPKeepAlive, Concurrency, WritePause, AsyncDial
 		}
 		conn, err := redisconn.Connect(ctx, "127.0.0.1:6379", opts)
 		return conn, err

rediscluster/mapping.go

@@ -38,7 +38,7 @@ func (c *Cluster) newNode(addr string, initial bool) (*node, error) {
 		addr:   addr,
 		refcnt: 1,
 	}
-	node.opts.Async = true
+	node.opts.AsyncDial = true
 	node.conns = make([]*redisconn.Connection, c.opts.ConnsPerHost)
 	for i := range node.conns {
 		node.opts.Handle = ClusterHandle{c.opts.Handle, addr, i}

redisconn/conn.go

@@ -58,8 +58,8 @@ type Opts struct {
 	WritePause time.Duration
 	// Logger
 	Logger Logger
-	// Async - do not establish connection immediately
-	Async bool
+	// AsyncDial - do not establish connection immediately
+	AsyncDial bool
 }
 
 // Connection is implementation of redis.Sender which represents single connection to single redis instance.
@@ -143,7 +143,7 @@ func Connect(ctx context.Context, addr string, opts Opts) (conn *Connection, err
 		conn.opts.Logger = DefaultLogger{}
 	}
 
-	if !conn.opts.Async {
+	if !conn.opts.AsyncDial {
 		if err = conn.createConnection(false, nil); err != nil {
 			if opts.ReconnectPause < 0 {
 				return nil, err
@@ -154,7 +154,7 @@ func Connect(ctx context.Context, addr string, opts Opts) (conn *Connection, err
 		}
 	}
 
-	if conn.opts.Async || err != nil {
+	if conn.opts.AsyncDial || err != nil {
 		var wg sync.WaitGroup
 		wg.Add(1)
 		go func() {
@@ -164,7 +164,7 @@ func Connect(ctx context.Context, addr string, opts Opts) (conn *Connection, err
 		}()
 		// in async mode we are still waiting for state to set to connConnecting
 		// so that Send will put requests into queue
-		if conn.opts.Async {
+		if conn.opts.AsyncDial {
 			wg.Wait()
 		}
 	}