Skip to content

Commit 8075691

Browse files
committed
separate stack trace in tests
1 parent 826cd09 commit 8075691

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

panic_test.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,18 +116,19 @@ func TestPanicChain(t *testing.T) {
116116
ch0 := make(chan error, 1)
117117
ch1 := make(chan error, 1)
118118

119-
doMischief(ch1)
120-
doMoreMischief(ch0, ch1)
119+
go doMischief(ch1)
120+
go doMoreMischief(ch0, ch1)
121121

122122
select {
123123
case err := <-ch0:
124124
require.Error(t, err)
125+
require.False(t, IsOfType(err, AssertionFailed))
125126
output := fmt.Sprintf("%+v", err)
126127
require.Contains(t, output, "mischiefProper", output)
127128
require.Contains(t, output, "mischiefAsPanic", output)
128129
require.Contains(t, output, "doMischief", output)
129130
require.Contains(t, output, "handleMischief", output)
130-
require.Contains(t, output, "doMoreMischief", output)
131+
require.NotContains(t, output, "doMoreMischief", output) // stack trace is only enhanced in Panic, not in user code
131132
t.Log(output)
132133
case <-time.After(time.Second):
133134
require.Fail(t, "expected error")
@@ -163,7 +164,7 @@ func doMischief(ch chan error) {
163164
return
164165
}
165166
}
166-
ch <- AssertionFailed.New("test failed") // todo check
167+
ch <- AssertionFailed.New("test failed")
167168
}()
168169

169170
mischiefAsPanic()

0 commit comments

Comments
 (0)