Tentative, re-sending kit params should likely not be needed anymore.

Author: jmamma

build/manifest.ini

@@ -22,3 +22,11 @@ version_code = 4070
 commit = 3632bb87
 filename = mcl_4_7_0.uf2
 
+[avr]
+checksum = 0x928c
+size = 245450
+version_string = 4.70
+version_code = 4070
+commit = 17fd3df8
+filename = mcl_4_7_0.hex
+

src/mcl/MCL/MDSeqTrack.cpp

@@ -591,24 +591,16 @@ void MDSeqTrack::reset_params() {
     //notes.prog = MD.kit.params[track_number][20];
     //process_note_locks(20, MD.kit.params[track_number][20],ccs);
     send_notes_ccs(ccs, send_ccs);
-  } else {
+  }
+#if defined(__AVR__)
+  else {
+    //Ugly hack, removing this section of code causes the avr compiler to bloat
+    if (track_number < 255) { return; }
     MDTrack md_track;
     md_track.get_machine_from_kit(track_number);
     MD.assignMachineBulk(track_number, &md_track.machine, 255, 1, true);
   }
-
-  /*
-  for (uint8_t c = 0; c < NUM_LOCKS; c++) {
-    bool send = false;
-    uint8_t send_param;
-    if (locks_params[c]) {
-      uint8_t p = locks_params[c] - 1;
-      uint8_t send_param = MD.kit.params[track_number][p];
-      bool update_kit = false;
-      MD.setTrackParam_inline(track_number, p, send_param, uart, update_kit);
-    }
-  }
-*/
+#endif
 }
 
 void MDSeqTrack::get_step_locks(uint8_t step, uint8_t *params,

src/mcl/MD/MD.cpp

@@ -630,7 +630,7 @@ void MDClass::setMuteGroup(uint8_t srcTrack, uint8_t muteTrack) {
   sendRequest(data, countof(data));
 }
 
-void MDClass::assignMachine(uint8_t track, uint8_t model, uint8_t init) {
+__attribute__((noinline)) void MDClass::assignMachine(uint8_t track, uint8_t model, uint8_t init) {
   uint8_t send_length = 5;
   if (init == 255) {
     send_length = 4;
@@ -681,7 +681,7 @@ void MDClass::setMachine(uint8_t track, MDMachine *machine) {
   //  uart->useRunningStatus = false;
 }
 
-uint8_t MDClass::assignMachineBulk(uint8_t track, MDMachine *machine,
+__attribute__((noinline)) uint8_t MDClass::assignMachineBulk(uint8_t track, MDMachine *machine,
                                    uint8_t level, uint8_t mode, bool send) {
 
   DEBUG_PRINT("assign machine bulk: ");

src/mcl/MD/MD.h

@@ -243,7 +243,7 @@ class MDClass : public ElektronDevice {
    * Send a sysex machine to change the model of the machine on the given track.
    **/
   void assignMachine(uint8_t track, uint8_t model, uint8_t init = 255);
-  uint8_t assignMachineBulk(uint8_t track, MDMachine *machine, uint8_t send_level, uint8_t mode = 255, bool send = true);
+  __attribute__((noinline)) uint8_t assignMachineBulk(uint8_t track, MDMachine *machine, uint8_t send_level, uint8_t mode = 255, bool send = true);
   /**
    * Load the given machine (including parameters) on the given track
    * out of the machine structure.