Guard to prevent extra kit fetches. Encoder regression

Author: jmamma

src/mcl/MCL/FXPage.cpp

@@ -81,7 +81,7 @@ void FXPage::display() {
     strncpy(str, param_name, 4);
     str[3] = '\0';
 
-    mcl_gui.draw_knob(i, encoders[i], str, false);
+    mcl_gui.draw_knob(i, encoders[i], str, false, false);
     //  mcl_gui.draw_light_encoder(30 + 20 * i, 18, encoders[i], str);
   }
   oled_display.setFont(&TomThumb);

src/mcl/MCL/PageSelectPage.cpp

@@ -97,6 +97,7 @@ void PageSelectPage::init() {
   // clear trigled so it's always sent on first run
   trigled_mask = 0;
   draw_popup();
+  MidiUartParent::handle_midi_lock = 1;
   md_prepare();
   MidiUartParent::handle_midi_lock = _midi_lock_tmp;
 }
@@ -109,11 +110,23 @@ void PageSelectPage::draw_popup() {
 }
 
 void PageSelectPage::md_prepare() {
+  //static uint16_t last_kit_request_time = 0;
+  //uint16_t current_time = read_clock_ms();
+  // Don't request if callback is already waiting for a response
+  if (kit_cb.state) {
+    return;
+  }
+  // Only request kit if more than 2 seconds (2000ms) has passed
+  //if (clock_diff(last_kit_request_time, current_time) < 2000) {
+  //  return;
+  //}
+
   kit_cb.init();
   auto listener = MD.getSysexListener();
   listener->addOnMessageCallback(
       &kit_cb, (sysex_callback_ptr_t)&MDCallback::onReceived);
   MD.requestKit(0x7F);
+  //last_kit_request_time = current_time;
 }
 
 void PageSelectPage::cleanup() {

src/mcl/MCL/PerfPage.cpp

@@ -245,9 +245,10 @@ void PerfPage::display() {
 
   PerfEncoder *e = perf_encoders[perf_id];
 
-  char perf_label[] = " A";
+  static char perf_label[4] = " A";
   perf_label[1] = 'A' + perf_id;
-  mcl_gui.draw_knob(0, encoders[0], perf_label, false);
+  perf_label[2] = '\0';
+  mcl_gui.draw_knob(0, encoders[0], perf_label, false, false);
 
   if (learn) {
     draw_dest(1, encoders[1]->cur);