Skip to content

Commit 5cfd613

Browse files
authored
ci(jenkins): skip Windows executable signing when RUN_CHOCOLATEY is disabled (#3520)
Gate the Windows signing block in build() and the downloadToolsCert() call on params.RUN_CHOCOLATEY so dev/test runs without the Chocolatey stage don't require the signing cert and Docker-based signing step.
1 parent 80496a2 commit 5cfd613

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

Jenkinsfile

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,9 @@ def runRelease(architectures) {
145145
}
146146

147147
// We sign the binary also for the standalone Windows executable, and not just for Windows executable packaged inside Chocolaty.
148-
downloadToolsCert()
148+
if (params.RUN_CHOCOLATEY) {
149+
downloadToolsCert()
150+
}
149151
if (params.RUN_UPLOAD_CLI) {
150152
stage('Upload CLI') {
151153
print "Uploading version $version to Repo21"
@@ -445,7 +447,7 @@ def build(goos, goarch, pkg, fileName) {
445447
env.GOOS=""
446448
env.GOARCH=""
447449

448-
if (goos == 'windows') {
450+
if (goos == 'windows' && params.RUN_CHOCOLATEY) {
449451
dir("${jfrogCliRepoDir}build/sign") {
450452
// Move the jfrog executable into the 'sign' directory, so that it is signed there.
451453
sh "mv ${jfrogCliRepoDir}${fileName} ${fileName}.unsigned"

0 commit comments

Comments
 (0)