Ensure date functions are flagged as isAggregateFn

Date functions are considered as aggregate functions from salesforce, so this fixes a bug to ensure we match behavior.

resolves #228

Author: paustint

CHANGELOG.md

@@ -1,7 +1,17 @@
 # Changelog
 
+## 4.8.0
+
+April 9, 2023
+
+- Fix `isAggregateFn` (#228)
+  - Date functions, such as `HOUR_IN_DAY(CreatedDate)` did not properly have the `isAggregateFn` property set to true for the field.
+  - As a result, `getFlattenedFields` would produce incorrect results for these fields if they were not aliased.
+
 ## 4.7.1
 
+January 23rd, 2023
+
 The repository was moved from `paustint` to `jetstreamapp`. No code changes.
 
 ## 4.7.0

src/parser/visitor.ts

@@ -592,7 +592,7 @@ class SOQLVisitor extends BaseSoqlVisitor {
   }
 
   dateFunction(ctx: FieldFunctionContext, options: { includeType: boolean } = { includeType: true }) {
-    return this.helpers.$_getFieldFunction(ctx, false, options.includeType);
+    return this.helpers.$_getFieldFunction(ctx, true, options.includeType);
   }
 
   aggregateFunction(ctx: FieldFunctionContext, options: { includeType: boolean } = { includeType: true }) {

test/public-utils-test-data.ts

@@ -692,4 +692,37 @@ export const testCases: FlattenedObjTestCase[] = [
       SBQQ__Quote__c: 'a116g000007R9yVAAS',
     },
   },
+  {
+    testCase: 20,
+    expectedFields: ['expr0'],
+    query: {
+      fields: [
+        {
+          type: 'FieldFunctionExpression',
+          functionName: 'CALENDAR_MONTH',
+          parameters: ['CreatedDate'],
+          isAggregateFn: true,
+          rawValue: 'CALENDAR_MONTH(CreatedDate)',
+        },
+      ],
+      sObject: 'Account',
+      groupBy: [
+        {
+          fn: { functionName: 'CALENDAR_MONTH', parameters: ['CreatedDate'], rawValue: 'CALENDAR_MONTH(CreatedDate)' },
+        },
+      ],
+      having: {
+        left: {
+          fn: { functionName: 'CALENDAR_MONTH', parameters: ['CreatedDate'], rawValue: 'CALENDAR_MONTH(CreatedDate)' },
+          operator: '!=',
+          value: '2',
+          literalType: 'INTEGER',
+        },
+      },
+    },
+    sfdcObj: {
+      attributes: { type: 'AggregateResult' },
+      expr0: 3,
+    },
+  },
 ];

test/test-cases.ts

@@ -1171,6 +1171,7 @@ export const testCases: TestCase[] = [
           type: 'FieldFunctionExpression',
           functionName: 'CALENDAR_YEAR',
           parameters: ['CreatedDate'],
+          isAggregateFn: true,
           rawValue: 'CALENDAR_YEAR(CreatedDate)',
           alias: 'calYear',
         },
@@ -1204,6 +1205,7 @@ export const testCases: TestCase[] = [
               rawValue: 'convertTimezone(CreatedDate)',
             },
           ],
+          isAggregateFn: true,
           rawValue: 'CALENDAR_YEAR(convertTimezone(CreatedDate))',
           alias: 'calYear',
         },
@@ -1428,6 +1430,7 @@ export const testCases: TestCase[] = [
               rawValue: 'convertTimezone(CreatedDate)',
             },
           ],
+          isAggregateFn: true,
           rawValue: 'HOUR_IN_DAY(convertTimezone(CreatedDate))',
         },
         {
@@ -2046,6 +2049,7 @@ export const testCases: TestCase[] = [
           type: 'FieldFunctionExpression',
           functionName: 'WEEK_IN_YEAR',
           parameters: ['CloseDate'],
+          isAggregateFn: true,
           rawValue: 'WEEK_IN_YEAR(CloseDate)',
         },
         {
@@ -2086,6 +2090,7 @@ export const testCases: TestCase[] = [
           type: 'FieldFunctionExpression',
           functionName: 'WEEK_IN_YEAR',
           parameters: ['CloseDate'],
+          isAggregateFn: true,
           rawValue: 'WEEK_IN_YEAR(CloseDate)',
         },
         {
@@ -2128,6 +2133,7 @@ export const testCases: TestCase[] = [
           type: 'FieldFunctionExpression',
           functionName: 'WEEK_IN_YEAR',
           parameters: ['CloseDate'],
+          isAggregateFn: true,
           rawValue: 'WEEK_IN_YEAR(CloseDate)',
         },
         {
@@ -2242,6 +2248,7 @@ export const testCases: TestCase[] = [
         {
           type: 'FieldFunctionExpression',
           functionName: 'CALENDAR_MONTH',
+          isAggregateFn: true,
           rawValue: 'CALENDAR_MONTH(LoginTime)',
           parameters: ['LoginTime'],
           alias: 'month',