-
Notifications
You must be signed in to change notification settings - Fork 26
Modernize lts-candidate-stats script #765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize lts-candidate-stats script #765
Conversation
Signed-off-by: Alexander Brandes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on my machine, @MarkEWaite possible for you to test too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very, very much! @lemeurherve and I were wrestling with issues with the predecessor script on his macOS machine. I was wrestling with issues on my Red Hat Enterprise Linux machine and had to revert to my Ubuntu machine.
I've made several updates to the script based on my testing. I have not tested my revisions on a macOS machine. @timja or @lemeurherve , could you test it on macOS?
Co-authored-by: Mark Waite <[email protected]>
Co-authored-by: Mark Waite <[email protected]>
Co-authored-by: Mark Waite <[email protected]>
Co-authored-by: Mark Waite <[email protected]>
Co-authored-by: Mark Waite <[email protected]>
Co-authored-by: Mark Waite <[email protected]>
Co-authored-by: Mark Waite <[email protected]>
Signed-off-by: Alexander Brandes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I confirmed that the script runs for me on Linux. Thanks very, very much for the rewrite!
The script works well on my Ubuntu 22.04 computer with xmllint 20913 and on my Fedora 42 computer with xmllint 21210.
It does not show output on my Red Hat Enterprise Linux 8 computer with xmllint 20907.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on my mac
The change proposed rewrites the script in bash, given:
Took me some time to get a working version with the JIRA API, a 1:1 conversion produced nothing but gibberish.
For 2.528.1, this produces
Given we use autolinks in core, the JENKINS- reference is always clickable, the URL is just for console usage, if desired.
This matches the output of jenkinsci/jenkins#11130, just swapped, given I value fixes higher than postpones.
Fixes #384