Add flake8 pluin flake8 bugbear to pre-commit (TheAlgorithms#7132)

* ci(pre-commit): Add ``flake8-builtins`` additional dependency to ``pre-commit`` (TheAlgorithms#7104)

* refactor: Fix ``flake8-builtins`` (TheAlgorithms#7104)

* fix(lru_cache): Fix naming conventions in docstrings (TheAlgorithms#7104)

* ci(pre-commit): Order additional dependencies alphabetically (TheAlgorithms#7104)

* fix(lfu_cache): Correct function name in docstring (TheAlgorithms#7104)

* Update strings/snake_case_to_camel_pascal_case.py

Co-authored-by: Christian Clauss <[email protected]>

* Update data_structures/stacks/next_greater_element.py

Co-authored-by: Christian Clauss <[email protected]>

* Update digital_image_processing/index_calculation.py

Co-authored-by: Christian Clauss <[email protected]>

* Update graphs/prim.py

Co-authored-by: Christian Clauss <[email protected]>

* Update hashes/djb2.py

Co-authored-by: Christian Clauss <[email protected]>

* refactor: Rename `_builtin` to `builtin_` ( TheAlgorithms#7104)

* fix: Rename all instances (TheAlgorithms#7104)

* refactor: Update variable names (TheAlgorithms#7104)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* ci: Create ``tox.ini`` and ignore ``A003`` (TheAlgorithms#7123)

* revert: Remove function name changes (TheAlgorithms#7104)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Rename tox.ini to .flake8

* Update data_structures/heap/heap.py

Co-authored-by: Dhruv Manilawala <[email protected]>

* refactor: Rename `next_` to `next_item` (TheAlgorithms#7104)

* ci(pre-commit): Add `flake8` plugin `flake8-bugbear` (TheAlgorithms#7127)

* refactor: Follow `flake8-bugbear` plugin (TheAlgorithms#7127)

* fix: Correct `knapsack` code (TheAlgorithms#7127)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: Christian Clauss <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Dhruv Manilawala <[email protected]>

Author: 4 people

.pre-commit-config.yaml

@@ -40,7 +40,10 @@ repos:
           - --ignore=E203,W503
           - --max-complexity=25
           - --max-line-length=88
-        additional_dependencies: [flake8-builtins, pep8-naming]
+        additional_dependencies:
+          - flake8-bugbear
+          - flake8-builtins
+          - pep8-naming
 
   - repo: https://github.com/pre-commit/mirrors-mypy
     rev: v0.982

arithmetic_analysis/jacobi_iteration_method.py

@@ -110,7 +110,7 @@ def jacobi_iteration_method(
     strictly_diagonally_dominant(table)
 
     # Iterates the whole matrix for given number of times
-    for i in range(iterations):
+    for _ in range(iterations):
         new_val = []
         for row in range(rows):
             temp = 0

arithmetic_analysis/newton_forward_interpolation.py

@@ -23,7 +23,7 @@ def ucal(u: float, p: int) -> float:
 def main() -> None:
     n = int(input("enter the numbers of values: "))
     y: list[list[float]] = []
-    for i in range(n):
+    for _ in range(n):
         y.append([])
     for i in range(n):
         for j in range(n):

arithmetic_analysis/secant_method.py

@@ -20,7 +20,7 @@ def secant_method(lower_bound: float, upper_bound: float, repeats: int) -> float
     """
     x0 = lower_bound
     x1 = upper_bound
-    for i in range(0, repeats):
+    for _ in range(0, repeats):
         x0, x1 = x1, x1 - (f(x1) * (x1 - x0)) / (f(x1) - f(x0))
     return x1
 

audio_filters/butterworth_filter.py

@@ -11,7 +11,7 @@
 
 
 def make_lowpass(
-    frequency: int, samplerate: int, q_factor: float = 1 / sqrt(2)
+    frequency: int, samplerate: int, q_factor: float = 1 / sqrt(2)  # noqa: B008
 ) -> IIRFilter:
     """
     Creates a low-pass filter
@@ -39,7 +39,7 @@ def make_lowpass(
 
 
 def make_highpass(
-    frequency: int, samplerate: int, q_factor: float = 1 / sqrt(2)
+    frequency: int, samplerate: int, q_factor: float = 1 / sqrt(2)  # noqa: B008
 ) -> IIRFilter:
     """
     Creates a high-pass filter
@@ -67,7 +67,7 @@ def make_highpass(
 
 
 def make_bandpass(
-    frequency: int, samplerate: int, q_factor: float = 1 / sqrt(2)
+    frequency: int, samplerate: int, q_factor: float = 1 / sqrt(2)  # noqa: B008
 ) -> IIRFilter:
     """
     Creates a band-pass filter
@@ -96,7 +96,7 @@ def make_bandpass(
 
 
 def make_allpass(
-    frequency: int, samplerate: int, q_factor: float = 1 / sqrt(2)
+    frequency: int, samplerate: int, q_factor: float = 1 / sqrt(2)  # noqa: B008
 ) -> IIRFilter:
     """
     Creates an all-pass filter
@@ -121,7 +121,10 @@ def make_allpass(
 
 
 def make_peak(
-    frequency: int, samplerate: int, gain_db: float, q_factor: float = 1 / sqrt(2)
+    frequency: int,
+    samplerate: int,
+    gain_db: float,
+    q_factor: float = 1 / sqrt(2),  # noqa: B008
 ) -> IIRFilter:
     """
     Creates a peak filter
@@ -150,7 +153,10 @@ def make_peak(
 
 
 def make_lowshelf(
-    frequency: int, samplerate: int, gain_db: float, q_factor: float = 1 / sqrt(2)
+    frequency: int,
+    samplerate: int,
+    gain_db: float,
+    q_factor: float = 1 / sqrt(2),  # noqa: B008
 ) -> IIRFilter:
     """
     Creates a low-shelf filter
@@ -184,7 +190,10 @@ def make_lowshelf(
 
 
 def make_highshelf(
-    frequency: int, samplerate: int, gain_db: float, q_factor: float = 1 / sqrt(2)
+    frequency: int,
+    samplerate: int,
+    gain_db: float,
+    q_factor: float = 1 / sqrt(2),  # noqa: B008
 ) -> IIRFilter:
     """
     Creates a high-shelf filter

backtracking/sum_of_subsets.py

@@ -39,14 +39,14 @@ def create_state_space_tree(
     if sum(path) == max_sum:
         result.append(path)
         return
-    for num_index in range(num_index, len(nums)):
+    for index in range(num_index, len(nums)):
         create_state_space_tree(
             nums,
             max_sum,
-            num_index + 1,
-            path + [nums[num_index]],
+            index + 1,
+            path + [nums[index]],
             result,
-            remaining_nums_sum - nums[num_index],
+            remaining_nums_sum - nums[index],
         )
 
 

boolean_algebra/quine_mc_cluskey.py

@@ -56,7 +56,7 @@ def decimal_to_binary(no_of_variable: int, minterms: Sequence[float]) -> list[st
     temp = []
     for minterm in minterms:
         string = ""
-        for i in range(no_of_variable):
+        for _ in range(no_of_variable):
             string = str(minterm % 2) + string
             minterm //= 2
         temp.append(string)

ciphers/mixed_keyword_cypher.py

@@ -40,7 +40,7 @@ def mixed_keyword(key: str = "college", pt: str = "UNIVERSITY") -> str:
     k = 0
     for _ in range(r):
         s = []
-        for j in range(len_temp):
+        for _ in range(len_temp):
             s.append(temp[k])
             if not (k < 25):
                 break

ciphers/rabin_miller.py

@@ -11,7 +11,7 @@ def rabin_miller(num: int) -> bool:
         s = s // 2
         t += 1
 
-    for trials in range(5):
+    for _ in range(5):
         a = random.randrange(2, num - 1)
         v = pow(a, s, num)
         if v != 1:

compression/burrows_wheeler.py

@@ -154,7 +154,7 @@ def reverse_bwt(bwt_string: str, idx_original_string: int) -> str:
         )
 
     ordered_rotations = [""] * len(bwt_string)
-    for x in range(len(bwt_string)):
+    for _ in range(len(bwt_string)):
         for i in range(len(bwt_string)):
             ordered_rotations[i] = bwt_string[i] + ordered_rotations[i]
         ordered_rotations.sort()