Skip to content

Commit fa2d5d5

Browse files
committed
Amend a few tests and types for linting.
1 parent 9929fd3 commit fa2d5d5

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

types/collectionsjs/collectionsjs-tests.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,7 @@ collection.last(); // $ExpectType { name: string; age: number; }
4141
collection.map(stark => stark.name); // $ExpectType Collection<{ name: string; age: number; }>
4242
collection.pluck('name'); // $ExpectType Collection<{ name: string; age: number; }>
4343
collection.push({name: 'Robb Stark', age: 17}); // $ExpectType Collection<{ name: string; age: number; }>
44-
45-
const value = new Collection([1, 2, 3]).reduce(
46-
(previous, current) => previous + current,
47-
0
48-
); // $ExpectType number
44+
const value = new Collection([1, 2, 3]).reduce((previous, current) => previous + current, 0); // $ExpectType number
4945
collection.reject(stark => stark.age < 14); // $ExpectType Collection<{ name: string; age: number; }>
5046
collection.remove({name: 'Robb Stark', age: 17}); // $ExpectType boolean
5147
collection.reverse(); // $ExpectType Collection<{ name: string; age: number; }>
@@ -56,9 +52,7 @@ collection.sortBy('name'); // $ExpectType Collection<{ name: string; age: number
5652
collection.stringify(); // $ExpectType string
5753
collection.sum('age'); // $ExpectType any
5854
collection.take(2); // $ExpectType Collection<{ name: string; age: number; }>
59-
60-
// Collection.macro('addToMembers', (collection, n) => collection.map((collectionItem: any) => collectionItem + n));
61-
// const collection2 = new Collection([1,2,3,4]).addToMembers(3);
55+
Collection.macro('addToMembers', (collection, n) => collection.map((collectionItem: any) => collectionItem + n));
6256

6357
collection.unique(stark => stark.age); // $ExpectType Collection<{ name: string; age: number; }>
6458
collection.values(); // $ExpectType Collection<{ name: string; age: number; }>

types/collectionsjs/index.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,12 @@ export default class Collection<T> {
3636
sort(compare?: () => boolean): Collection<T>;
3737
sortBy(property: string, order?: string): Collection<T>;
3838
stringify(): string;
39-
sum(property: T extends object ? keyof T : never): number
39+
sum(property: T extends object ? keyof T : never): number;
4040
take(count: number): Collection<T>;
4141
static macro(name: string, callback: (coll: Collection<unknown>, ...args: unknown[]) => unknown): void;
4242
unique(callback?: string|null|((item: T) => any)): Collection<T>;
4343
values(): Collection<T>;
44-
where<K extends keyof T>(key: K, value: T[K]): Collection<T>
45-
where(callback: (item: T) => boolean): Collection<T>
44+
where<K extends keyof T>(key: K, value: T[K]): Collection<T>;
45+
where(callback: (item: T) => boolean): Collection<T>;
4646
zip(array: T[]|Collection<T>): Collection<T>;
4747
}

0 commit comments

Comments
 (0)