Skip to content

Commit d4f392f

Browse files
authored
Add undefined to optional properties, React to Regenerate (DefinitelyTyped#54352)
* Add undefined to optional properties, React to Regenerate In preparation for exactOptionalPropertyTypes in Typescript 4.4, add undefined to all optional properties. #no-publishing-comment This PR covers widely used packages, those with more then 100,000 packages per month, from react-slider -- regenerate microsoft/dtslint#335 * Fix errors in react * Missed fix to react-table * add missed parens to conditional type
1 parent c9c4f05 commit d4f392f

File tree

92 files changed

+3679
-3679
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

92 files changed

+3679
-3679
lines changed

types/react-slider/index.d.ts

Lines changed: 32 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -15,23 +15,23 @@ interface HTMLPropsWithRefCallback<T> extends HTMLProps<T> {
1515

1616
export interface ReactSliderProps<T extends number | ReadonlyArray<number> = number> {
1717
// Disallow children
18-
children?: never;
18+
children?: never | undefined;
1919

2020
/**
2121
* `aria-label` for screen-readers to apply to the thumb(s).
2222
*
2323
* Use an array for more than one thumb.
2424
* The length of the array must match the number of thumbs in the `value` array.
2525
*/
26-
ariaLabel?: T extends number ? string : ReadonlyArray<string>;
26+
ariaLabel?: T extends number ? string : ReadonlyArray<string> | undefined;
2727

2828
/**
2929
* aria-labelledby for screen-readers to apply to the thumbs.
3030
* Used when slider rendered with separate label.
3131
* Use an array for more than one thumb.
3232
* The length of the array must match the number of thumbs in the value array.
3333
*/
34-
ariaLabelledby?: T extends number ? string : ReadonlyArray<string>;
34+
ariaLabelledby?: T extends number ? string : ReadonlyArray<string> | undefined;
3535

3636
/**
3737
* `aria-valuetext` for screen-readers.
@@ -46,14 +46,14 @@ export interface ReactSliderProps<T extends number | ReadonlyArray<number> = num
4646
* - `state.value` - the current value state
4747
* - `state.valueNow` - the value of the thumb (i.e. aria-valuenow)
4848
*/
49-
ariaValuetext?: string | ((value: { index: number; value: T; valueNow: number }) => string);
49+
ariaValuetext?: string | ((value: { index: number; value: T; valueNow: number }) => string) | undefined;
5050

5151
/**
5252
* The css class set on the slider node.
5353
*
5454
* @default "slider"
5555
*/
56-
className?: string;
56+
className?: string | undefined;
5757

5858
/**
5959
* Determines the initial position(s) of the thumb(s) and the number of thumbs.
@@ -67,28 +67,28 @@ export interface ReactSliderProps<T extends number | ReadonlyArray<number> = num
6767
*
6868
* @default 0
6969
*/
70-
defaultValue?: this["value"] extends T ? never : T;
70+
defaultValue?: (this["value"] extends T ? never : T) | undefined;
7171

7272
/**
7373
* If `true` the thumbs can't be moved.
7474
*
7575
* @default false
7676
*/
77-
disabled?: boolean;
77+
disabled?: boolean | undefined;
7878

7979
/**
8080
* Inverts the slider.
8181
*
8282
* @default false
8383
*/
84-
invert?: boolean;
84+
invert?: boolean | undefined;
8585

8686
/**
8787
* The CSS class set on the marks.
8888
*
8989
* @default "mark"
9090
*/
91-
markClassName?: string;
91+
markClassName?: string | undefined;
9292

9393
/**
9494
* Shows passed marks on the track, if `true` it shows all the marks;
@@ -98,67 +98,67 @@ export interface ReactSliderProps<T extends number | ReadonlyArray<number> = num
9898
*
9999
* @default []
100100
*/
101-
marks?: boolean | number | ReadonlyArray<number>;
101+
marks?: boolean | number | ReadonlyArray<number> | undefined;
102102

103103
/**
104104
* The maximum value of the slider.
105105
*
106106
* @default 100
107107
*/
108-
max?: number;
108+
max?: number | undefined;
109109

110110
/**
111111
* The minimum value of the slider.
112112
*
113113
* @default 0
114114
*/
115-
min?: number;
115+
min?: number | undefined;
116116

117117
/**
118118
* The minimal distance between any pair of thumbs.
119119
* Must be positive, but `0` means they can sit on top of each other.
120120
*
121121
* @default 0
122122
*/
123-
minDistance?: number;
123+
minDistance?: number | undefined;
124124

125125
/**
126126
* Callback called only after moving a thumb has ended. The callback
127127
* will only be called if the action resulted in a change.
128128
*
129129
* - `value` - the result value, or values if the slider has multiple thumbs and the thumb index
130130
*/
131-
onAfterChange?: (value: T, index: number) => void;
131+
onAfterChange?: ((value: T, index: number) => void) | undefined;
132132

133133
/**
134134
* Callback called before starting to move a thumb. The callback will
135135
* only be called if the action will result in a change.
136136
*
137137
* - `value` - the initial value, or values if the slider has multiple thumbs and the thumb index
138138
*/
139-
onBeforeChange?: (value: T, index: number) => void;
139+
onBeforeChange?: ((value: T, index: number) => void) | undefined;
140140

141141
/**
142142
* Callback called on every value change.
143143
*
144144
* - `value` - the new value, or values if the slider has multiple thumbs and the thumb index
145145
*/
146-
onChange?: (value: T, index: number) => void;
146+
onChange?: ((value: T, index: number) => void) | undefined;
147147

148148
/**
149149
* Callback called when the the slider is clicked (thumb or tracks).
150150
*
151151
* - `value` - the value at the clicked position
152152
*/
153-
onSliderClick?: (value: number) => void;
153+
onSliderClick?: ((value: number) => void) | undefined;
154154

155155
/**
156156
* Determines whether the slider moves horizontally (from left to right)
157157
* or vertically (from top to bottom).
158158
*
159159
* @default "horizontal"
160160
*/
161-
orientation?: "horizontal" | "vertical";
161+
orientation?: "horizontal" | "vertical" | undefined;
162162

163163
/**
164164
* The result of the function is the value to be added or subtracted
@@ -168,15 +168,15 @@ export interface ReactSliderProps<T extends number | ReadonlyArray<number> = num
168168
*
169169
* @default step => step * 10
170170
*/
171-
pageFn?: (step: number) => number;
171+
pageFn?: ((step: number) => number) | undefined;
172172

173173
/**
174174
* If `true` the active thumb will push other thumbs within the constraints
175175
* of `min`, `max`, `step` and `minDistance`.
176176
*
177177
* @default false
178178
*/
179-
pearling?: boolean;
179+
pearling?: boolean | undefined;
180180

181181
/**
182182
* Provide a custom render function for the mark node.
@@ -188,7 +188,7 @@ export interface ReactSliderProps<T extends number | ReadonlyArray<number> = num
188188
*
189189
* @default props => <div {...props} />
190190
*/
191-
renderMark?: (props: HTMLPropsWithRefCallback<HTMLSpanElement>) => JSX.Element | null;
191+
renderMark?: ((props: HTMLPropsWithRefCallback<HTMLSpanElement>) => JSX.Element | null) | undefined;
192192

193193
/**
194194
* Provide a custom render function for dynamic thumb content.
@@ -203,10 +203,10 @@ export interface ReactSliderProps<T extends number | ReadonlyArray<number> = num
203203
*
204204
* @default props => <div {...props} />
205205
*/
206-
renderThumb?: (
206+
renderThumb?: ((
207207
props: HTMLPropsWithRefCallback<HTMLDivElement>,
208208
state: { index: number; value: T; valueNow: number },
209-
) => JSX.Element | null;
209+
) => JSX.Element | null) | undefined;
210210

211211
/**
212212
* Provide a custom render function for the track node.
@@ -220,17 +220,17 @@ export interface ReactSliderProps<T extends number | ReadonlyArray<number> = num
220220
*
221221
* @default props => <div {...props} />
222222
*/
223-
renderTrack?: (
223+
renderTrack?: ((
224224
props: HTMLPropsWithRefCallback<HTMLDivElement>,
225225
state: { index: number; value: T },
226-
) => JSX.Element | null;
226+
) => JSX.Element | null) | undefined;
227227

228228
/**
229229
* Disables thumb move when clicking the slider track
230230
*
231231
* @default false
232232
*/
233-
snapDragDisabled?: boolean;
233+
snapDragDisabled?: boolean | undefined;
234234

235235
/**
236236
* Value to be added or subtracted on each step the slider makes.
@@ -239,13 +239,13 @@ export interface ReactSliderProps<T extends number | ReadonlyArray<number> = num
239239
*
240240
* @default 1
241241
*/
242-
step?: number;
242+
step?: number | undefined;
243243

244244
/**
245245
* The css class set on the thumb that is currently being moved.
246246
* @default "active"
247247
*/
248-
thumbActiveClassName?: string;
248+
thumbActiveClassName?: string | undefined;
249249

250250
/**
251251
* The css class set on each thumb node.
@@ -254,7 +254,7 @@ export interface ReactSliderProps<T extends number | ReadonlyArray<number> = num
254254
* `${thumbClassName}-${i}`, e.g. `thumb-0`, `thumb-1`, ...
255255
* @default "thumb"
256256
*/
257-
thumbClassName?: string;
257+
thumbClassName?: string | undefined;
258258

259259
/**
260260
* The css class set on the tracks between the thumbs.
@@ -263,19 +263,19 @@ export interface ReactSliderProps<T extends number | ReadonlyArray<number> = num
263263
* `${trackClassName}-${i}`, e.g. `track-0`, `track-1`, ...
264264
* @default "track"
265265
*/
266-
trackClassName?: string;
266+
trackClassName?: string | undefined;
267267

268268
/**
269269
* Like `defaultValue` but for
270270
* [controlled components](http://facebook.github.io/react/docs/forms.html#controlled-components).
271271
*/
272-
value?: T;
272+
value?: T | undefined;
273273

274274
/**
275275
* If `true` tracks between the thumbs will be rendered.
276276
* @default true
277277
*/
278-
withTracks?: boolean;
278+
withTracks?: boolean | undefined;
279279
}
280280

281281
declare class ReactSlider<T extends number | ReadonlyArray<number> = number> extends Component<ReactSliderProps<T>> {

types/react-sticky/index.d.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,17 @@ export interface StickyChildArgs {
2323

2424
export interface StickyProps {
2525
children: (args: StickyChildArgs) => React.ReactElement;
26-
relative?: boolean;
27-
isActive?: boolean;
28-
className?: string;
26+
relative?: boolean | undefined;
27+
isActive?: boolean | undefined;
28+
className?: string | undefined;
2929
style?: any;
30-
stickyClassName?: string;
30+
stickyClassName?: string | undefined;
3131
stickyStyle?: any;
32-
topOffset?: number;
33-
bottomOffset?: number;
32+
topOffset?: number | undefined;
33+
bottomOffset?: number | undefined;
3434
onStickyStateChange?(isSticky: boolean): void;
35-
disableCompensation?: boolean;
36-
disableHardwareAcceleration?: boolean;
35+
disableCompensation?: boolean | undefined;
36+
disableHardwareAcceleration?: boolean | undefined;
3737
}
3838

3939
export const Sticky: React.ComponentClass<StickyProps>;

types/react-stripe-elements/index.d.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,18 +24,18 @@ export namespace ReactStripeElements {
2424
type ElementsOptions = stripe.elements.ElementsOptions;
2525
// From https://stripe.com/docs/stripe-js/reference#element-types
2626
type TokenType = 'card' | 'cardNumber' | 'cardExpiry' | 'cardCvc' | 'paymentRequestButton' | 'iban' | 'idealBank';
27-
type TokenOptions = stripe.TokenOptions & { type?: TokenType };
27+
type TokenOptions = stripe.TokenOptions & { type?: TokenType | undefined };
2828
type TokenResponse = stripe.TokenResponse;
2929
type SourceResponse = stripe.SourceResponse;
3030
type SourceOptions = stripe.SourceOptions;
3131
type HTMLStripeElement = stripe.elements.Element;
3232

3333
interface StripeProviderOptions {
34-
stripeAccount?: string;
34+
stripeAccount?: string | undefined;
3535
}
3636
type StripeProviderProps =
37-
| { apiKey: string; stripe?: never } & StripeProviderOptions
38-
| { apiKey?: never; stripe: stripe.Stripe | null } & StripeProviderOptions;
37+
| { apiKey: string; stripe?: never | undefined } & StripeProviderOptions
38+
| { apiKey?: never | undefined; stripe: stripe.Stripe | null } & StripeProviderOptions;
3939

4040
interface StripeOverrideProps {
4141
/*
@@ -69,7 +69,7 @@ export namespace ReactStripeElements {
6969
}
7070

7171
interface InjectOptions {
72-
withRef?: boolean;
72+
withRef?: boolean | undefined;
7373
}
7474

7575
interface InjectedStripeProps {
@@ -78,9 +78,9 @@ export namespace ReactStripeElements {
7878
}
7979

8080
interface ElementProps extends ElementsOptions {
81-
id?: string;
81+
id?: string | undefined;
8282

83-
className?: string;
83+
className?: string | undefined;
8484

8585
elementRef?(ref: any): void;
8686

types/react-swipeable-views-utils/index.d.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ import { OnChangeIndexCallback, OnSwitchingCallback, OnTransitionEndCallback } f
1212
export interface WithAutoPlay {
1313
index: number;
1414
onChangeIndex: OnChangeIndexCallback;
15-
onSwitching?: OnSwitchingCallback;
15+
onSwitching?: OnSwitchingCallback | undefined;
1616
}
1717
export interface WithAutoPlayProps {
18-
autoplay?: boolean;
19-
direction?: 'incremental' | 'decremental';
18+
autoplay?: boolean | undefined;
19+
direction?: 'incremental' | 'decremental' | undefined;
2020
index: number;
21-
interval?: number;
21+
interval?: number | undefined;
2222
onChangeIndex: OnChangeIndexCallback;
23-
slideCount?: number;
23+
slideCount?: number | undefined;
2424
}
2525

2626
export interface WithVirtualize {
@@ -31,11 +31,11 @@ export interface WithVirtualize {
3131
export interface WithVirtualizeProps {
3232
index: number;
3333
onChangeIndex: OnChangeIndexCallback;
34-
onTransitionEnd?: OnTransitionEndCallback;
35-
overscanSlideAfter?: number;
36-
overscanSlideBefore?: number;
37-
slideCount?: number;
38-
children?: React.ReactNode;
34+
onTransitionEnd?: OnTransitionEndCallback | undefined;
35+
overscanSlideAfter?: number | undefined;
36+
overscanSlideBefore?: number | undefined;
37+
slideCount?: number | undefined;
38+
children?: React.ReactNode | undefined;
3939
slideRenderer: SlideRendererCallback;
4040
}
4141
export interface SlideRenderProps {
@@ -48,10 +48,10 @@ export interface WithBindKeyboard {
4848
onChangeIndex: OnChangeIndexCallback;
4949
}
5050
export interface WithBindKeyboardProps {
51-
axis?: "x" | "x-reverse" | "y" | "y-reverse";
51+
axis?: "x" | "x-reverse" | "y" | "y-reverse" | undefined;
5252
index: number;
5353
onChangeIndex: OnChangeIndexCallback;
54-
slidecount?: number;
54+
slidecount?: number | undefined;
5555
}
5656

5757
export const autoPlay: PropInjector<WithAutoPlay, WithAutoPlayProps>;

0 commit comments

Comments
 (0)