Skip to content

Commit 86fbf93

Browse files
author
Ben
authored
🤖 Merge PR DefinitelyTyped#57974 [Memoizee] Added string as a possible type to options/promise by @benediktkaiser
* added string as a type option to promise * updated version number * removed patch version * Update index.d.ts * Added new test for done:finally * changed how the tests work * Update memoizee-tests.ts * fixed tests
1 parent 8369673 commit 86fbf93

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

‎types/memoizee/index.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ declare namespace memoizee {
1111
maxAge?: number | undefined;
1212
max?: number | undefined;
1313
preFetch?: number | true | undefined;
14-
promise?: boolean | undefined;
14+
promise?: boolean | "then" | "done" | "done:finally" | undefined;
1515
dispose?(value: any): void;
1616
async?: boolean | undefined;
1717
primitive?: boolean | undefined;

‎types/memoizee/memoizee-tests.ts

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,21 @@ memoized(String({ toString() { return "12"; } }), Number({}));
4242
const afn = (a: number, b: number) => {
4343
return new Promise(res => { res(a + b); });
4444
};
45-
const memoized = memoize(afn, { promise: true });
45+
let memoized = memoize(afn, { promise: true });
4646
memoized(3, 7);
4747
memoized(3, 7);
48+
49+
memoized = memoize(afn, { promise: 'then' });
50+
memoized(2, 7);
51+
memoized(2, 7);
52+
53+
memoized = memoize(afn, { promise: 'done' });
54+
memoized(5, 7);
55+
memoized(5, 7);
56+
57+
memoized = memoize(afn, { promise: 'done:finally' });
58+
memoized(8, 7);
59+
memoized(8, 7);
4860
}
4961

5062
memoized = memoize(fn, { maxAge: 1000, preFetch: 0.6 });

0 commit comments

Comments
 (0)