Fix remaining lint errors (DefinitelyTyped#19219)

Author: Andy

types/activex-adodb/activex-adodb-tests.ts

@@ -14,9 +14,7 @@ let obj5 = new ActiveXObject('ADODB.Stream');
 let pathToExcelFile = 'C:\\path\\to\\excel\\file.xlsx';
 let conn = new ActiveXObject('ADODB.Connection');
 conn.Provider = 'Microsoft.ACE.OLEDB.12.0';
-conn.ConnectionString =
-    'Data Source="' + pathToExcelFile + '";' +
-    'Extended Properties="Excel 12.0;HDR=Yes"';
+conn.ConnectionString = `Data Source="${pathToExcelFile}";Extended Properties="Excel 12.0;HDR=Yes"`;
 conn.Open();
 
 // create a Command to access the data

types/activex-scripting/activex-scripting-tests.ts

@@ -40,9 +40,9 @@ function showFileAttributes(file: Scripting.File) {
 function showFreeSpace(drvPath: string) {
     const fso = new ActiveXObject('Scripting.FileSystemObject');
     const d = fso.GetDrive(fso.GetDriveName(drvPath));
-    let s = 'Drive ' + drvPath + ' - ';
+    let s = `Drive ${drvPath} - `;
     s += d.VolumeName + '<br>';
-    s += 'Free Space: ' + d.FreeSpace / 1024 + ' Kbytes';
+    s += `Free Space: ${d.FreeSpace / 1024} Kbytes`;
     return (s);
 }
 

types/activex-wia/activex-wia-tests.ts

@@ -37,14 +37,14 @@ let e = new Enumerator<WIA.Property>(dev.Properties);  // no foreach over Active
 e.moveFirst();
 while (!e.atEnd()) {
     const p = e.item();
-    let s = p.Name + ' (' + p.PropertyID + ') = ';
+    let s = `${p.Name} (${p.PropertyID}) = `;
     if (p.IsVector) {
         s += '[vector of data]';
     } else {
         s += p.Value;
         if (p.SubType !== WIA.WiaSubType.UnspecifiedSubType) {
             if (p.Value !== p.SubTypeDefault) {
-                s += ' (Default = ' + p.SubTypeDefault + ')';
+                s += ` (Default = ${p.SubTypeDefault})`;
             }
         }
     }
@@ -70,7 +70,7 @@ while (!e.atEnd()) {
                 s += ']';
                 break;
             case WIA.WiaSubType.RangeSubType:
-                s += ' [valid values in the range from ' + p.SubTypeMin + ' to ' + p.SubTypeMax + ' in increments of ' + p.SubTypeStep + ']';
+                s += ` [valid values in the range from ${p.SubTypeMin} to ${p.SubTypeMax} in increments of ${p.SubTypeStep}]`;
                 break;
         }
     }

types/algebra.js/algebra.js-tests.ts

@@ -36,7 +36,7 @@ import { Equation, Expression, Fraction, parse, toTex } from 'algebra.js';
   let expr1 = new Expression("a").add("b").add("c");
   let expr2 = new Expression("c").subtract("b");
   let expr3 = expr1.subtract(expr2);
-  expr1.toString() + " - (" + expr2.toString() + ") = " + expr3.toString();
+  `${expr1.toString()} - (${expr2.toString()}) = ${expr3.toString()}`;
 
   expr1 = new Expression("x");
   expr1 = expr1.add(2);
@@ -46,7 +46,7 @@ import { Equation, Expression, Fraction, parse, toTex } from 'algebra.js';
   expr2 = expr2.multiply(new Fraction(1, 3));
   expr2 = expr2.add(4);
   expr3 = expr1.multiply(expr2);
-  "(" + expr1.toString() + ")(" + expr2.toString() + ") = " + expr3.toString();
+  `(${expr1.toString()})(${expr2.toString()}) = ${expr3.toString()}`;
 
   x = new Expression("x").divide(2).divide(new Fraction(1, 5));
   x.toString();
@@ -58,7 +58,7 @@ import { Equation, Expression, Fraction, parse, toTex } from 'algebra.js';
   sum.toString();
   exp = new Expression("x").add(2);
   const exp3 = exp.pow(3);
-  "(" + exp.toString() + ")^3 = " + exp3.toString();
+  `(${exp.toString()})^3 = ${exp3.toString()}`;
 
   let expr = new Expression("x");
   expr = expr.multiply(2);

types/angular/angular-tests.ts

@@ -620,7 +620,7 @@ function test_angular_forEach() {
     const log: string[] = [];
     angular.forEach(values, (value, key, obj) => {
         obj[key] = value;
-        this.push(key + ': ' + value);
+        this.push(`${key}: ${value}`);
     }, log);
     // expect(log).toEqual(['name: misko', 'gender: male']);
 }

types/awesomplete/awesomplete-tests.ts

@@ -35,7 +35,7 @@ new Awesomplete('input[type="email"]', {
            "hotmail.co.uk", "mac.com", "me.com", "mail.com", "msn.com",
            "live.com", "sbcglobal.net", "verizon.net", "yahoo.com", "yahoo.co.uk"],
     data: (text: string, input: string) => {
-        return input.slice(0, input.indexOf("@")) + "@" + text;
+        return `${input.slice(0, input.indexOf("@"))}@${text}`;
     },
     filter: Awesomplete.FILTER_STARTSWITH
 });
@@ -47,7 +47,7 @@ new Awesomplete('input[data-multiple]', {
 
     replace: (text: string) => {
         const before = this.input.value.match(/^.+,\s*|/)[0];
-        this.input.value = before + text + ", ";
+        this.input.value = `${before}${text}, `;
     }
 });
 

types/bagpipes/tslint.json

@@ -1,6 +1,8 @@
 {
     "extends": "dtslint/dt.json",
     "rules": {
-        "callable-types": false
+        // TODOs
+        "callable-types": false,
+        "no-object-literal-type-assertion": false
     }
 }

types/better-sqlite3/better-sqlite3-tests.ts

@@ -1,7 +1,7 @@
 import * as Database from 'better-sqlite3';
 
-let integer = Database.Integer(1);
-let err = new Database.SqliteError('ok', 'ok');
+const integer = Database.Integer(1);
+const err = new Database.SqliteError('ok', 'ok');
 
 let db = Database('.');
 db = new Database('.', {memory: true});
@@ -15,7 +15,7 @@ db.register({name: 'noop', deterministic: true, varargs: true}, () => {});
 db.defaultSafeIntegers();
 db.defaultSafeIntegers(true);
 
-let stmt = db.prepare('SELECT * FROM test WHERE name == ?;');
+const stmt = db.prepare('SELECT * FROM test WHERE name == ?;');
 stmt.get(['name']);
 stmt.all({name: 'name'});
 stmt.each('name', (row: {name: string}) => {});
@@ -26,7 +26,7 @@ stmt.bind('name');
 stmt.safeIntegers();
 stmt.safeIntegers(true);
 
-let trans = db.transaction(['INSERT INTO test(name) VALUES(?);']);
+const trans = db.transaction(['INSERT INTO test(name) VALUES(?);']);
 trans.run('name');
 trans.bind('name');
 trans.run();

types/better-sqlite3/index.d.ts

@@ -1,6 +1,6 @@
 // Type definitions for better-sqlite3 3.1
 // Project: http://github.com/JoshuaWise/better-sqlite3
-// Definitions by: Ben Davies <https://github.com/Morfent/>
+// Definitions by: Ben Davies <https://github.com/Morfent>
 // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
 
 /// <reference types="node" />

types/bootstrap-slider/bootstrap-slider-tests.ts

@@ -12,7 +12,7 @@ $(() => {
     $('#ex2').slider({});
 
     const RGBChange = () => {
-        $('#RGB').css('background', 'rgb(' + r.getValue() + ',' + g.getValue() + ',' + b.getValue() + ')');
+        $('#RGB').css('background', `rgb(${r.getValue()},${g.getValue()},${b.getValue()})`);
     };
 
     const r = $('#R').slider()