combining patch not working (O_RESTOREPREVIEW=1) problem

[ahloiscreamo]

nnn master*​​
❯ make O_NERD=1 O_RESTOREPREVIEW=1
cc -DNERD -DICONS_INCLUDE="icons-generated-nerd.h" -std=c11 -Wall -Wextra -Wshadow -O3 -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -DICONS_GENERATE -o src/icons-hash-gen src/icons-hash.c
./src/icons-hash-gen > src/icons-generated-nerd.h
patching file src/nnn.c
Hunk #1 succeeded at 402 (offset 6 lines).
Hunk #2 succeeded at 535 (offset 7 lines).
Hunk #3 succeeded at 716 (offset 7 lines).
Hunk #4 succeeded at 733 (offset 7 lines).
Hunk #5 succeeded at 872 (offset 7 lines).
Hunk #6 succeeded at 3190 (offset 18 lines).
Hunk #7 succeeded at 5437 (offset 59 lines).
Hunk #8 succeeded at 5479 (offset 59 lines).
Hunk #9 succeeded at 6182 (offset 59 lines).
Hunk #10 succeeded at 6198 (offset 59 lines).
Hunk #11 succeeded at 6236 (offset 59 lines).
Hunk #12 succeeded at 6267 (offset 57 lines).
Hunk #13 succeeded at 6931 (offset 48 lines).
Hunk #14 succeeded at 7190 (offset 48 lines).
Hunk #15 succeeded at 7352 (offset 48 lines).
Hunk #16 succeeded at 7693 (offset 57 lines).
Hunk #17 succeeded at 8089 (offset 57 lines).
Hunk #18 succeeded at 8115 (offset 57 lines).
Hunk #19 succeeded at 8179 (offset 57 lines).
Hunk #20 succeeded at 8738 (offset 57 lines).
Hunk #21 succeeded at 9292 (offset 63 lines).
cc -DNERD -DICONS_INCLUDE="icons-generated-nerd.h" -std=c11 -Wall -Wextra -Wshadow -O3 -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -o nnn src/nnn.c -lreadline -lncursesw -lpthread
patching file src/nnn.c
Hunk #1 succeeded at 402 (offset 6 lines).
Hunk #2 succeeded at 534 (offset 7 lines).
Hunk #3 succeeded at 712 (offset 7 lines).
Hunk #4 succeeded at 728 (offset 7 lines).
Hunk #5 succeeded at 866 (offset 7 lines).
Hunk #6 succeeded at 3184 (offset 18 lines).
Hunk #7 succeeded at 5431 (offset 59 lines).
Hunk #8 succeeded at 5468 (offset 59 lines).
Hunk #9 succeeded at 6156 (offset 59 lines).
Hunk #10 succeeded at 6172 (offset 59 lines).
Hunk #11 succeeded at 6204 (offset 59 lines).
Hunk #12 succeeded at 6235 (offset 57 lines).
Hunk #13 succeeded at 6899 (offset 48 lines).
Hunk #14 succeeded at 7158 (offset 48 lines).
Hunk #15 succeeded at 7320 (offset 48 lines).
Hunk #16 succeeded at 7654 (offset 57 lines).
Hunk #17 succeeded at 8044 (offset 57 lines).
Hunk #18 succeeded at 8069 (offset 57 lines).
Hunk #19 succeeded at 8127 (offset 57 lines).
Hunk #20 succeeded at 8680 (offset 57 lines).
Hunk #21 succeeded at 9232 (offset 63 lines).

nnn master*​​ 3s
❯ sudo make install
[sudo] password for ahloi:
cc -std=c11 -Wall -Wextra -Wshadow -O3 -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -o nnn src/nnn.c -lreadline -lncursesw -lpthread
install -m 0755 -d /usr/local/bin
install -m 0755 nnn /usr/local/bin
install -m 0755 -d /usr/local/share/man/man1
install -m 0644 nnn.1 /usr/local/share/man/man1

nnn master*​​ 6s
❯

start nnn, no patch working, no icon, restore preview not work.
but if i patch icon only

nnn master*​​
❯ make O_NERD=1
cc -DNERD -DICONS_INCLUDE="icons-generated-nerd.h" -std=c11 -Wall -Wextra -Wshadow -O3 -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -DICONS_GENERATE -o src/icons-hash-gen src/icons-hash.c
./src/icons-hash-gen > src/icons-generated-nerd.h
cc -DNERD -DICONS_INCLUDE="icons-generated-nerd.h" -std=c11 -Wall -Wextra -Wshadow -O3 -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -o nnn src/nnn.c -lreadline -lncursesw -lpthread

nnn master*​​ 3s
❯ sudo make install
install -m 0755 -d /usr/local/bin
install -m 0755 nnn /usr/local/bin
install -m 0755 -d /usr/local/share/man/man1
install -m 0644 nnn.1 /usr/local/share/man/man1

nnn master*​​
❯

it work fine, and since icon work fine, i compile with make O_RESTOREPREVIEW=1 only, but it's not working.
This is on latest git

❯ git log -1 --pretty=format:"%h - %as"

e362117 - 2025-05-27

nnn master*​

❯

env

~

❯ env | grep NNN

NNN_OPENER_DETACH=1

NNN_PLUG=a:addtoplaylist;j:autojump;p:preview-tui;i:imgview;l:launch;r:renamer;w:wallpaper;o:organize;x:xdgdefault

NNN_FCOLORS=0B0405020006060009060B01

NNN_OPENER=xdg-open

NNN_PREVIEW=/tmp/nnn-preview-tui-fifopid.

NNN_EDITOR=/usr/bin/vim

NNN_VISUAL=vim

NNN_FIFO=/tmp/nnn.fifo nnn

NNN_BMS=m:/mnt;g:/mnt/Kingston/gallery-dl/instagram;d:/Downloads;p:/Pictures;t:/Documents;f:/Desktop

NNN_COLORS=5632

~

❯

[N-R-K]

❯ sudo make install
[sudo] password for ahloi:
cc -std=c11 -Wall -Wextra -Wshadow -O3 -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -o nnn src/nnn.c -lreadline -lncursesw -lpthread

This ended up recompiling the binary, but without the flags hence your issue. Run sudo make O_NERD=1 O_RESTOREPREVIEW=1 install directly and it should work.

Though I guess we could try to reset the mtime of the source file after unpatching so that it doesn't trigger unnecessary re-compilation.

[ahloiscreamo]

I see, thank you very much everything fixed now ! 🙏