Use String.replace() where possible

See spring-projects/spring-framework#35025 and https://medium.com/javarevisited/micro-optimizations-in-java-string-replaceall-c6d0edf2ef6

Signed-off-by: Johnny Lim <[email protected]>

Author: izeye

implementations/micrometer-registry-influx/src/main/java/io/micrometer/influx/InfluxNamingConvention.java

@@ -48,7 +48,7 @@ public InfluxNamingConvention(NamingConvention delegate) {
 
     @Override
     public String name(String name, Meter.Type type, @Nullable String baseUnit) {
-        return escape(delegate.name(name, type, baseUnit).replace("=", "_"));
+        return escape(delegate.name(name, type, baseUnit).replace('=', '_'));
     }
 
     @Override

micrometer-core/src/main/java/io/micrometer/core/instrument/binder/jvm/JvmThreadMetrics.java

@@ -104,7 +104,7 @@ static long getThreadStateCount(ThreadMXBean threadBean, Thread.State state) {
     }
 
     private static String getStateTagValue(Thread.State state) {
-        return state.name().toLowerCase(Locale.ROOT).replace("_", "-");
+        return state.name().toLowerCase(Locale.ROOT).replace('_', '-');
     }
 
 }

micrometer-core/src/main/java/io/micrometer/core/instrument/binder/kafka/KafkaConsumerMetrics.java

@@ -428,7 +428,7 @@ private Iterable<Tag> nameTag(ObjectName name) {
     }
 
     private static String sanitize(String value) {
-        return value.replaceAll("-", ".");
+        return value.replace('-', '.');
     }
 
     @Override

micrometer-core/src/main/java/io/micrometer/core/instrument/binder/kafka/KafkaMetrics.java

@@ -318,7 +318,7 @@ private double toDouble(@Nullable Metric metric) {
 
     private List<Tag> meterTags(MetricName metricName, boolean includeCommonTags) {
         List<Tag> tags = new ArrayList<>();
-        metricName.tags().forEach((key, value) -> tags.add(Tag.of(key.replaceAll("-", "."), value)));
+        metricName.tags().forEach((key, value) -> tags.add(Tag.of(key.replace('-', '.'), value)));
         tags.add(Tag.of(KAFKA_VERSION_TAG_NAME, kafkaVersion));
         extraTags.forEach(tags::add);
         if (includeCommonTags) {
@@ -333,7 +333,7 @@ private List<Tag> meterTags(MetricName metricName) {
 
     private String meterName(MetricName metricName) {
         String name = METRIC_NAME_PREFIX + metricName.group() + "." + metricName.name();
-        return name.replaceAll("-metrics", "").replaceAll("-", ".");
+        return name.replaceAll("-metrics", "").replace('-', '.');
     }
 
     private Meter.Id meterIdForComparison(MetricName metricName) {

micrometer-core/src/main/java/io/micrometer/core/instrument/binder/tomcat/TomcatMetrics.java

@@ -386,7 +386,7 @@ private long safeLong(Callable<Object> callable) {
     private Iterable<Tag> nameTag(ObjectName name) {
         String nameTagValue = name.getKeyProperty("name");
         if (nameTagValue != null) {
-            return Tags.of("name", nameTagValue.replaceAll("\"", ""));
+            return Tags.of("name", nameTagValue.replace("\"", ""));
         }
         return Collections.emptyList();
     }

micrometer-core/src/main/java/io/micrometer/core/instrument/util/HierarchicalNameMapper.java

@@ -36,7 +36,7 @@ public interface HierarchicalNameMapper {
             convention) -> id.getConventionName(convention) + id.getConventionTags(convention)
                 .stream()
                 .map(t -> "." + t.getKey() + "." + t.getValue())
-                .map(nameSegment -> nameSegment.replace(" ", "_"))
+                .map(nameSegment -> nameSegment.replace(' ', '_'))
                 .collect(Collectors.joining(""));
 
     String toHierarchicalName(Meter.Id id, NamingConvention convention);