Please add a shortcut to quit rups

[sciurius]

In particular on the Linux and macOS desktops, almost every application can be terminated with a Ctrl-Q shortcut.

It would be very nice if this shortcut would be added to rups.

[Eswcvlad]

Hmm, well I've tested on macOS, and the app is closed on Cmd-Q, as expected.

But on Linux, yes, it still uses Alt-F4, while most DEs default to Ctrl-Q. Should be easy to fix.

[sciurius]

On my Fedora Linux systems (MATE desktop) Alt-F4 has no effect.

Should be easy to fix.

Can you point me into the right direction?

I have added a Quit menu item with shortcut Ctrl-Q but I'm not sure what would be the correct method to call for an orderly termination. I currently use System.exit() but that's a bit rigorous ☺.

+        quitRups = addItem(
+                file,
+                Language.MENU_BAR_QUIT,
+                e -> System.exit(0),
+                KeyStroke.getKeyStroke('Q', InputEvent.CTRL_DOWN_MASK)
+        );

[Eswcvlad]

It is better to use a platform-specific mask instead of just Ctrl, as Cmd is expected on mac.

I currently use System.exit() but that's a bit rigorous ☺.

Practically speaking, we have EXIT_ON_CLOSE set for the main window at the moment, which is also just System.exit(0), so this handler would be, indeed, correct.

[Eswcvlad]

Should be available in the 26.01 release.

[sciurius]

Something is wrong...
When using Ctrl-Q or File>Exit the application window closes but the app itself keeps alive and needs to be killed manually.

Fedora 42, MATE desktop.

[Eswcvlad]

Hmm... Strange... That shouldn't be the case...

I'll check that out.

[Eswcvlad]

Tried in a f42 MATE VM and it seems to be working fine for me...

Does this happen all the time or only when specific files/menus are open? Also, which version of Java are you using?

[sciurius]

It is fully reproducable, e.g. start rups from command line and File>Exit. No menus, no files.

Java is openjdk 21.0.9 2025-10-21
OpenJDK Runtime Environment (Red_Hat-21.0.9.0.10-1) (build 21.0.9+10)
OpenJDK 64-Bit Server VM (Red_Hat-21.0.9.0.10-1) (build 21.0.9+10, mixed mode, sharing)

My window manager is OpenBox 3.6.1.

[sciurius]

FWIW, Help>Version gives 9.5.0 ?

Log from start rups w/o file and File>Exit attached.

rups.log

[Eswcvlad]

FWIW, Help>Version gives 9.5.0 ?

Yeah... Currently it shows iText Core library version used there... That matches RUPS 26.01.

Log from start rups w/o file and File>Exit attached.

Seems fine...

---

This is pretty strange. With the way it is implemented (i.e. via a WINDOW_CLOSING event), it should be equivalent to just clicking X on the window title frame. But I am assuming, that in that case everything is fine.

Does it work properly with how you did it before, with just System.exit(0)? Or java also remains stuck on something?