[RELEASE] iText 7 RUPS - 7.1.16

https://github.com/itext/i7j-rups/releases/tag/7.1.16

* release_branch_DEVSIX-5154:
  [RELEASE] RUPS 7.1.16
  Add PdfDocument/PdfReader constructors to try-with-resources
  Add TODO with a ticket for refactoring XML processing logic
  [AFTER RELEASE] RUPS 7.1.15

Author: iText-CI

pom.xml

@@ -5,7 +5,7 @@
   <parent>
     <groupId>com.itextpdf</groupId>
     <artifactId>root</artifactId>
-    <version>7.1.15</version>
+    <version>7.1.16</version>
     <relativePath />
   </parent>
 

src/main/java/com/itextpdf/rups/controller/RupsController.java

@@ -433,7 +433,8 @@ public CompareTool.CompareResult compareWithDocument(PdfDocument document) {
     }
 
     public CompareTool.CompareResult compareWithFile(File file) {
-        try (PdfDocument cmpDocument = new PdfDocument(new PdfReader(file.getAbsolutePath()))) {
+        try (PdfReader readerPdf = new PdfReader(file.getAbsolutePath());
+                PdfDocument cmpDocument = new PdfDocument(readerPdf)) {
             return compareWithDocument(cmpDocument);
         } catch (IOException e) {
             LoggerHelper.warn(LoggerMessages.CREATE_COMPARE_DOC_ERROR, e, getClass());
@@ -442,19 +443,13 @@ public CompareTool.CompareResult compareWithFile(File file) {
     }
 
     public CompareTool.CompareResult compareWithStream(InputStream is) {
-        PdfDocument cmpDocument = null;
-        try {
-            PdfReader reader = new PdfReader(is);
+        try (PdfReader reader = new PdfReader(is);
+                PdfDocument cmpDocument = new PdfDocument(reader)) {
             reader.setCloseStream(false);
-            cmpDocument = new PdfDocument(reader);
             return compareWithDocument(cmpDocument);
         } catch (IOException e) {
             LoggerHelper.warn(LoggerMessages.CREATE_COMPARE_DOC_ERROR, e, getClass());
             return null;
-        } finally {
-            if (cmpDocument != null) {
-                cmpDocument.close();
-            }
         }
     }
 

src/main/java/com/itextpdf/rups/model/XfaFile.java

@@ -78,6 +78,7 @@ public XfaFile(OutputStreamResource resource) throws IOException, DocumentExcept
         ByteArrayOutputStream baos = new ByteArrayOutputStream();
         resource.writeTo(baos);
         ByteArrayInputStream bais = new ByteArrayInputStream(baos.toByteArray());
+        // TODO DEVSIX-5299 refactor logic to use XML processing from com.itextpdf.kernel.utils.XmlUtils
         SAXReader reader = new SAXReader();
         reader.setEntityResolver(new SafeEmptyEntityResolver());
         xfaDocument = reader.read(bais);