Add Sonar refactorings. RES-713

Author: michaeldemey

src/main/java/com/itextpdf/rups/controller/PdfReaderController.java

@@ -46,7 +46,6 @@ This file is part of the iText (R) project.
 import com.itextpdf.kernel.pdf.PdfDictionary;
 import com.itextpdf.kernel.pdf.PdfIndirectReference;
 import com.itextpdf.kernel.pdf.PdfName;
-import com.itextpdf.kernel.pdf.PdfNull;
 import com.itextpdf.kernel.pdf.PdfObject;
 import com.itextpdf.kernel.pdf.PdfStream;
 import com.itextpdf.kernel.utils.CompareTool;
@@ -317,7 +316,7 @@ public void update(Observable observable, Object obj) {
                     nodes.expandNode(root);
                     IndirectObjectFactory objects = loader.getObjects();
                     List<PdfIndirectReference> objectStreams = objects.getObjectStreams();
-                    if ( objectStreams != null && objectStreams.size() > 0 ) {
+                    if ( objectStreams != null && !objectStreams.isEmpty() ) {
                         ObjectStreamTreeNode objStreamNode = new ObjectStreamTreeNode(new PdfArray(objectStreams));
                         root.add(objStreamNode);
                         nodes.expandNode(objStreamNode);

src/main/java/com/itextpdf/rups/view/Language.java

@@ -188,6 +188,7 @@ public enum Language {
     PAGES,
     PAGES_TABLE_OBJECT,
     PDF_READING,
+    PDF_OBJECT_STREAMS_TREE_NODE,
     PDF_OBJECT_TREE,
     PLAINTEXT,
     PLAINTEXT_DESCRIPTION,

src/main/java/com/itextpdf/rups/view/itext/XRefTable.java

@@ -187,10 +187,10 @@ private String getByteOffSetByRow(int rowIndex) {
                 PdfIndirectReference streamIndRef = objectByIndex.getIndirectReference();
                 long streamOffset = streamIndRef.getOffset();
 
-                String formattedString =
-                        String.format(Language.XREF_BYTE_OFFSET_OBJECT_STREAM.getString(), objStreamNumber, streamOffset);
-
-                return formattedString;
+                return String.format(
+                        Language.XREF_BYTE_OFFSET_OBJECT_STREAM.getString(),
+                        objStreamNumber, streamOffset
+                );
             }
 
             return String.valueOf(offset);

src/main/java/com/itextpdf/rups/view/itext/treenodes/ObjectStreamTreeNode.java

@@ -1,12 +1,13 @@
 package com.itextpdf.rups.view.itext.treenodes;
 
 import com.itextpdf.kernel.pdf.PdfObject;
+import com.itextpdf.rups.view.Language;
 
 public class ObjectStreamTreeNode extends PdfObjectTreeNode {
 
     public ObjectStreamTreeNode(PdfObject object) {
         super(object);
-        setUserObject("PDF Object Streams");
+        setUserObject(Language.PDF_OBJECT_STREAMS_TREE_NODE.getString());
     }
 
 }

src/main/resources/bundles/rups-lang.properties

@@ -144,6 +144,7 @@ PAGES=Pages
 PAGES_TABLE_OBJECT=Object %d
 
 PDF_READING=Reading PDF document...
+PDF_OBJECT_STREAMS_TREE_NODE=PDF Object Streams
 PDF_OBJECT_TREE=PDF Object Tree (%s)
 
 PLAINTEXT=Plain Text