You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+12-16Lines changed: 12 additions & 16 deletions
Original file line number
Diff line number
Diff line change
@@ -68,8 +68,7 @@ Before you submit your pull request consider the following guidelines:
68
68
* Verify that your proposed change hasn't already been addressed in the develop branch.
69
69
* Don't send a separate pull request for every single file you change.
70
70
* Please sign the [iText Contributor License Agreement (iCLA)](#cla) before sending pull
71
-
requests for any change of more than 20 significant lines of code (we're not counting curly braces and other syntactical sugar).
72
-
We cannot accept code without this agreement.
71
+
requests. We cannot accept code without this agreement.
73
72
* Fork the iText repository on GitHub.
74
73
* Clone your iText fork to your local machine.
75
74
* Make your changes, **including appropriate test cases**.
@@ -100,8 +99,7 @@ To ensure consistency throughout the source code, keep these rules in mind as yo
100
99
101
100
* We develop in Java first, and then port to .NET, so code submissions in Java are preferred.
102
101
Nevertheless this shouldn't stop you from making a good pull request to the .NET port.
103
-
* All Java code **must** be Java 7. Sorry, no lambda expressions or other Java 8 language features.
104
-
* All features or bug fixes **must be tested** by one or more [unit tests][unit-testing].
102
+
* All features or bug fixes **must be tested** by one or more unit tests.
105
103
* All public API methods **must be documented** with JavaDoc. To see how we document our APIs, please check
106
104
out the existing [javadocs][javadocs].
107
105
* We follow the rules contained in
@@ -151,8 +149,7 @@ reference JIRA or GitHub issues that this commit **Closes**.
151
149
152
150
## <aname="cla">Signing the iCLA</a>
153
151
154
-
Please sign the **iText Contributor License Agreement (iCLA)** before sending pull requests. For any larger code
155
-
changes (more than 20 lines of significant code) to be accepted, the iCLA must be signed. It's a quick process, we promise!
152
+
Please sign the [**iText Contributor License Agreement (iCLA)**][cla] before sending pull requests. For any code changes to be accepted, the iCLA must be signed. It's a quick process, we promise!
156
153
157
154
We'll need you to [(digitally) sign and then email, fax or mail the form][cla].
158
155
@@ -165,18 +162,17 @@ We use the [Stack Exchange][stackoverflow] network for free support and [GitHub]
0 commit comments