Fixed an issue where .getFontFromAcroForm() method was called on a pdf without an AcroForm, resulting in a NullPointerException.

This is fixed by adding an extra check on the availability of the AcroForm before querying it.

Author: KevinWillems

src/main/java/com/itextpdf/pdfcleanup/PdfCleanUpTool.java

@@ -453,11 +453,17 @@ private void drawRolloverAppearance(PdfCanvas canvas, PdfStream redactRolloverAp
     }
 
     private void drawOverlayText(PdfCanvas canvas, String overlayText, Rectangle annotRect, PdfBoolean repeat, PdfString defaultAppearance, int justification) throws IOException {
-        Map<String, List> parsedDA = parseDAParam(defaultAppearance);
+        Map<String, List> parsedDA;
+        try {
+            parsedDA = parseDAParam(defaultAppearance);
+        }catch (NullPointerException npe){
+            throw new PdfException(PdfException.DefaultAppearanceNotFound);
+        }
         PdfFont font;
         float fontSize = 12;
         List fontArgs = parsedDA.get("Tf");
-        if (fontArgs != null) {
+        PdfDictionary formDictionary = pdfDocument.getCatalog().getPdfObject().getAsDictionary(PdfName.AcroForm);
+        if (fontArgs != null && formDictionary != null) {
             font = getFontFromAcroForm((PdfName) fontArgs.get(0));
             fontSize = ((PdfNumber) fontArgs.get(1)).floatValue();
         } else {

src/test/java/com/itextpdf/pdfcleanup/PdfCleanUpToolTest.java

@@ -44,18 +44,24 @@ This file is part of the iText (R) project.
 
 
 import com.itextpdf.kernel.color.ColorConstants;
+import com.itextpdf.kernel.PdfException;
 import com.itextpdf.kernel.geom.PageSize;
 import com.itextpdf.kernel.geom.Rectangle;
 import com.itextpdf.kernel.pdf.PdfDocument;
 import com.itextpdf.kernel.pdf.PdfReader;
+import com.itextpdf.kernel.pdf.PdfString;
 import com.itextpdf.kernel.pdf.PdfWriter;
+import com.itextpdf.kernel.pdf.annot.PdfAnnotation;
+import com.itextpdf.kernel.pdf.annot.PdfRedactAnnotation;
 import com.itextpdf.kernel.utils.CompareTool;
 import com.itextpdf.test.ExtendedITextTest;
 import com.itextpdf.test.annotations.type.IntegrationTest;
 import org.junit.Assert;
 import org.junit.BeforeClass;
+import org.junit.Rule;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
+import org.junit.rules.ExpectedException;
 
 import java.io.IOException;
 import java.util.Arrays;
@@ -67,6 +73,9 @@ public class PdfCleanUpToolTest extends ExtendedITextTest {
     private static final String inputPath = "./src/test/resources/com/itextpdf/pdfcleanup/PdfCleanUpToolTest/";
     private static final String outputPath = "./target/test/com/itextpdf/pdfcleanup/PdfCleanUpToolTest/";
 
+    @Rule
+    public ExpectedException junitExpectedException = ExpectedException.none();
+
     @BeforeClass
     public static void before() {
         createOrClearDestinationFolder(outputPath);
@@ -537,6 +546,46 @@ public void cleanUpTest44() throws IOException, InterruptedException {
         compareByContent(cmp, output, outputPath, "diff_44");
     }
 
+    @Test
+    public void cleanUpTest45() throws IOException, InterruptedException {
+        String input = inputPath + "emptyPdf.pdf";
+        String output = outputPath + "emptyPdf.pdf";
+        String cmp = inputPath + "cmp_emptyPdf.pdf";
+
+        PdfAnnotation redactAnnotation = new PdfRedactAnnotation(new Rectangle(97, 405, 383, 40))
+                .setOverlayText(new PdfString("OverlayTest"))
+                .setDefaultAppearance(new PdfString("/Helv 0 Tf 0 g"));
+
+        PdfDocument pdfDocument = new PdfDocument(new PdfReader(input), new PdfWriter(output));
+
+        pdfDocument.getFirstPage().addAnnotation(redactAnnotation);
+
+        new PdfCleanUpTool(pdfDocument, true).cleanUp();
+
+        pdfDocument.close();
+        compareByContent(cmp, output, outputPath, "diff_45");
+    }
+
+    @Test
+    public void cleanUpTest46() throws IOException {
+        junitExpectedException.expect(PdfException.class);
+        junitExpectedException.expectMessage(PdfException.DefaultAppearanceNotFound);
+        
+        String input = inputPath + "emptyPdf.pdf";
+        String output = outputPath + "emptyPdf.pdf";
+
+        PdfAnnotation redactAnnotation = new PdfRedactAnnotation(new Rectangle(97, 405, 383, 40))
+                .setOverlayText(new PdfString("OverlayTest"));
+
+        PdfDocument pdfDocument = new PdfDocument(new PdfReader(input), new PdfWriter(output));
+
+        pdfDocument.getFirstPage().addAnnotation(redactAnnotation);
+
+        new PdfCleanUpTool(pdfDocument, true).cleanUp();
+
+        pdfDocument.close();
+    }
+
     private void cleanUp(String input, String output, List<PdfCleanUpLocation> cleanUpLocations) throws IOException {
         PdfDocument pdfDocument = new PdfDocument(new PdfReader(input), new PdfWriter(output));