Skip to content

Commit a399ee9

Browse files
nikitakovaliov92yulian-gaponenko
authored andcommitted
Rename the LogMessageConstant classes and move them into a separate package
DEVSIX-5773
1 parent 6858bb8 commit a399ee9

10 files changed

+30
-16
lines changed

src/main/java/com/itextpdf/pdfcleanup/PdfCleanUpFilter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ This file is part of the iText (R) project.
8080
import com.itextpdf.kernel.pdf.canvas.parser.data.TextRenderInfo;
8181
import com.itextpdf.kernel.pdf.xobject.PdfImageXObject;
8282
import com.itextpdf.pdfcleanup.exceptions.CleanupExceptionMessageConstant;
83+
import com.itextpdf.pdfcleanup.logs.CleanUpLogMessageConstant;
8384
import com.itextpdf.pdfcleanup.util.CleanUpHelperUtil;
8485
import com.itextpdf.pdfcleanup.util.CleanUpImageUtil;
8586

src/main/java/com/itextpdf/pdfcleanup/PdfCleanUpProcessor.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ This file is part of the iText (R) project.
101101
import java.util.Set;
102102
import java.util.Stack;
103103

104+
import com.itextpdf.pdfcleanup.logs.CleanUpLogMessageConstant;
104105
import com.itextpdf.pdfcleanup.util.CleanUpCsCompareUtil;
105106
import org.slf4j.Logger;
106107
import org.slf4j.LoggerFactory;

src/main/java/com/itextpdf/pdfcleanup/CleanUpLogMessageConstant.java renamed to src/main/java/com/itextpdf/pdfcleanup/logs/CleanUpLogMessageConstant.java

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,19 +20,28 @@ This file is part of the iText (R) project.
2020
You should have received a copy of the GNU Affero General Public License
2121
along with this program. If not, see <https://www.gnu.org/licenses/>.
2222
*/
23-
package com.itextpdf.pdfcleanup;
23+
package com.itextpdf.pdfcleanup.logs;
2424

2525
public class CleanUpLogMessageConstant {
2626

2727
/** The Constant CANNOT_OBTAIN_IMAGE_INFO_AFTER_FILTERING. */
2828
public static final String CANNOT_OBTAIN_IMAGE_INFO_AFTER_FILTERING = "Cannot obtain image info after filtering.";
29+
2930
/** The Constant FAILED_TO_PROCESS_A_TRANSFORMATION_MATRIX. */
30-
public static final String FAILED_TO_PROCESS_A_TRANSFORMATION_MATRIX = "Failed to process a transformation matrix which is noninvertible. Some content may be placed not as expected.";
31+
public static final String FAILED_TO_PROCESS_A_TRANSFORMATION_MATRIX =
32+
"Failed to process a transformation matrix which is noninvertible. Some content may be placed not as "
33+
+ "expected.";
34+
3135
/** The Constant IMAGE_MASK_CLEAN_UP_NOT_SUPPORTED. */
32-
public static final String IMAGE_MASK_CLEAN_UP_NOT_SUPPORTED = "Partial clean up of transparent images with mask encoded with one of the following filters is not supported: JBIG2Decode, DCTDecode, JPXDecode. Image will become non-transparent.";
36+
public static final String IMAGE_MASK_CLEAN_UP_NOT_SUPPORTED =
37+
"Partial clean up of transparent images with mask encoded with one of the following filters is not "
38+
+ "supported: JBIG2Decode, DCTDecode, JPXDecode. Image will become non-transparent.";
39+
3340
/** The Constant REDACTION_OF_ANNOTATION_TYPE_WATERMARK_IS_NOT_SUPPORTED. */
34-
public static final String REDACTION_OF_ANNOTATION_TYPE_WATERMARK_IS_NOT_SUPPORTED = "Redaction of annotation subtype /Watermark is not supported";
41+
public static final String REDACTION_OF_ANNOTATION_TYPE_WATERMARK_IS_NOT_SUPPORTED =
42+
"Redaction of annotation subtype /Watermark is not supported";
3543

3644
private CleanUpLogMessageConstant() {
45+
//Private constructor will prevent the instantiation of this class directly
3746
}
3847
}

src/main/java/com/itextpdf/pdfcleanup/util/CleanUpCsCompareUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ This file is part of the iText (R) project.
2626
import com.itextpdf.kernel.pdf.PdfName;
2727
import com.itextpdf.kernel.pdf.PdfObject;
2828
import com.itextpdf.kernel.pdf.xobject.PdfImageXObject;
29-
import com.itextpdf.pdfcleanup.CleanUpLogMessageConstant;
29+
import com.itextpdf.pdfcleanup.logs.CleanUpLogMessageConstant;
3030
import org.apache.commons.imaging.ImageInfo;
3131
import org.apache.commons.imaging.ImageReadException;
3232
import org.apache.commons.imaging.Imaging;

src/test/java/com/itextpdf/pdfcleanup/BigDocumentCleanUpTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ This file is part of the iText (R) project.
4242
*/
4343
package com.itextpdf.pdfcleanup;
4444

45-
import com.itextpdf.io.LogMessageConstant;
45+
import com.itextpdf.io.logs.IoLogMessageConstant;
4646
import com.itextpdf.kernel.geom.Rectangle;
4747
import com.itextpdf.kernel.pdf.PdfDocument;
4848
import com.itextpdf.kernel.pdf.PdfReader;
@@ -85,7 +85,7 @@ public void bigUntaggedDocument() throws IOException, InterruptedException {
8585
}
8686

8787
@Test
88-
@LogMessages(messages = @LogMessage(messageTemplate = LogMessageConstant.CREATED_ROOT_TAG_HAS_MAPPING))
88+
@LogMessages(messages = @LogMessage(messageTemplate = IoLogMessageConstant.CREATED_ROOT_TAG_HAS_MAPPING))
8989
public void bigTaggedDocument() throws IOException, InterruptedException {
9090
String input = inputPath + "chapter8_Interactive_features.pdf";
9191
String output = outputPath + "bigTaggedDocument.pdf";

src/test/java/com/itextpdf/pdfcleanup/CleanUpAnnotationTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ This file is part of the iText (R) project.
4949
import com.itextpdf.kernel.pdf.PdfReader;
5050
import com.itextpdf.kernel.pdf.PdfWriter;
5151
import com.itextpdf.kernel.utils.CompareTool;
52+
import com.itextpdf.pdfcleanup.logs.CleanUpLogMessageConstant;
5253
import com.itextpdf.test.ExtendedITextTest;
5354
import com.itextpdf.test.annotations.LogMessage;
5455
import com.itextpdf.test.annotations.LogMessages;

src/test/java/com/itextpdf/pdfcleanup/CleanUpCsCompareUtilTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ This file is part of the iText (R) project.
2626
import com.itextpdf.kernel.pdf.PdfNumber;
2727
import com.itextpdf.kernel.pdf.PdfStream;
2828
import com.itextpdf.kernel.pdf.xobject.PdfImageXObject;
29+
import com.itextpdf.pdfcleanup.logs.CleanUpLogMessageConstant;
2930
import com.itextpdf.pdfcleanup.util.CleanUpCsCompareUtil;
3031
import com.itextpdf.test.ExtendedITextTest;
3132
import com.itextpdf.test.annotations.LogMessage;

src/test/java/com/itextpdf/pdfcleanup/PdfCleanUpToolTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ This file is part of the iText (R) project.
4242
*/
4343
package com.itextpdf.pdfcleanup;
4444

45-
import com.itextpdf.io.LogMessageConstant;
45+
import com.itextpdf.io.logs.IoLogMessageConstant;
4646
import com.itextpdf.kernel.exceptions.PdfException;
4747
import com.itextpdf.kernel.colors.ColorConstants;
4848
import com.itextpdf.kernel.geom.PageSize;
@@ -57,6 +57,7 @@ This file is part of the iText (R) project.
5757
import com.itextpdf.pdfcleanup.autosweep.CompositeCleanupStrategy;
5858
import com.itextpdf.pdfcleanup.autosweep.RegexBasedCleanupStrategy;
5959
import com.itextpdf.pdfcleanup.exceptions.CleanupExceptionMessageConstant;
60+
import com.itextpdf.pdfcleanup.logs.CleanUpLogMessageConstant;
6061
import com.itextpdf.pdfcleanup.util.CleanUpImagesCompareTool;
6162
import com.itextpdf.test.ExtendedITextTest;
6263
import com.itextpdf.test.annotations.LogMessage;
@@ -778,7 +779,7 @@ public void cleanUpTestFontColor() throws IOException, InterruptedException {
778779
}
779780

780781
@Test
781-
@LogMessages(messages = @LogMessage(messageTemplate = LogMessageConstant.PDF_REFERS_TO_NOT_EXISTING_PROPERTY_DICTIONARY))
782+
@LogMessages(messages = @LogMessage(messageTemplate = IoLogMessageConstant.PDF_REFERS_TO_NOT_EXISTING_PROPERTY_DICTIONARY))
782783
public void noPropertiesInResourcesTest() throws IOException, InterruptedException {
783784
String fileName = "noPropertiesInResourcesTest";
784785
String input = INPUT_PATH + fileName + ".pdf";
@@ -791,7 +792,7 @@ public void noPropertiesInResourcesTest() throws IOException, InterruptedExcepti
791792
}
792793

793794
@Test
794-
@LogMessages(messages = @LogMessage(messageTemplate = LogMessageConstant.PDF_REFERS_TO_NOT_EXISTING_PROPERTY_DICTIONARY))
795+
@LogMessages(messages = @LogMessage(messageTemplate = IoLogMessageConstant.PDF_REFERS_TO_NOT_EXISTING_PROPERTY_DICTIONARY))
795796
public void incorrectBDCToBMCTest() throws IOException, InterruptedException {
796797
String fileName = "incorrectBDCToBMCTest";
797798
String input = INPUT_PATH + fileName + ".pdf";

src/test/java/com/itextpdf/pdfcleanup/PdfCleanUpToolWithInlineImagesTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ This file is part of the iText (R) project.
4343
package com.itextpdf.pdfcleanup;
4444

4545

46-
import com.itextpdf.io.LogMessageConstant;
46+
import com.itextpdf.io.logs.IoLogMessageConstant;
4747
import com.itextpdf.kernel.geom.Rectangle;
4848
import com.itextpdf.kernel.pdf.PdfDocument;
4949
import com.itextpdf.kernel.pdf.PdfReader;
@@ -76,7 +76,7 @@ public static void before() {
7676

7777
@Test
7878
@LogMessages(messages = {
79-
@LogMessage(messageTemplate = LogMessageConstant.IMAGE_SIZE_CANNOT_BE_MORE_4KB)
79+
@LogMessage(messageTemplate = IoLogMessageConstant.IMAGE_SIZE_CANNOT_BE_MORE_4KB)
8080
})
8181
public void cleanUpTest28() throws IOException, InterruptedException {
8282
String input = inputPath + "inlineImages.pdf";
@@ -101,7 +101,7 @@ public void cleanUpTest29() throws IOException, InterruptedException {
101101

102102
@Test
103103
@LogMessages(messages = {
104-
@LogMessage(messageTemplate = LogMessageConstant.IMAGE_SIZE_CANNOT_BE_MORE_4KB)
104+
@LogMessage(messageTemplate = IoLogMessageConstant.IMAGE_SIZE_CANNOT_BE_MORE_4KB)
105105
})
106106
public void cleanUpTest31() throws IOException, InterruptedException {
107107
String input = inputPath + "inlineImageCleanup.pdf";

src/test/java/com/itextpdf/pdfcleanup/text/CleanUpTextTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ This file is part of the iText (R) project.
4242
*/
4343
package com.itextpdf.pdfcleanup.text;
4444

45-
import com.itextpdf.io.LogMessageConstant;
45+
import com.itextpdf.io.logs.IoLogMessageConstant;
4646
import com.itextpdf.kernel.geom.Rectangle;
4747
import com.itextpdf.kernel.pdf.PdfDocument;
4848
import com.itextpdf.kernel.pdf.PdfReader;
@@ -74,8 +74,8 @@ public static void before() {
7474

7575
@Test
7676
@LogMessages(messages = {
77-
@LogMessage(messageTemplate = LogMessageConstant.FONT_DICTIONARY_WITH_NO_FONT_DESCRIPTOR),
78-
@LogMessage(messageTemplate = LogMessageConstant.FONT_DICTIONARY_WITH_NO_WIDTHS)})
77+
@LogMessage(messageTemplate = IoLogMessageConstant.FONT_DICTIONARY_WITH_NO_FONT_DESCRIPTOR),
78+
@LogMessage(messageTemplate = IoLogMessageConstant.FONT_DICTIONARY_WITH_NO_WIDTHS)})
7979
public void cleanZeroWidthTextInvalidFont() throws IOException, InterruptedException {
8080
String input = inputPath + "cleanZeroWidthTextInvalidFont.pdf";
8181
String output = outputPath + "cleanZeroWidthTextInvalidFont.pdf";

0 commit comments

Comments
 (0)