Finalize code related to form fields renderers separation

DEVSIX-7385

Author: Eugene Bochilo

commons/src/main/java/com/itextpdf/commons/utils/ExperimentalFeatures.java

@@ -10,11 +10,6 @@
   <name>iText - forms</name>
   <url>https://itextpdf.com/</url>
 
-  <properties>
-    <sonar.coverage.exclusions>**/forms/fields/TextAndChoiceLegacyDrawer.java</sonar.coverage.exclusions>
-    <sonar.cpd.exclusions>**/forms/fields/TextAndChoiceLegacyDrawer.java</sonar.cpd.exclusions>
-  </properties>
-  
   <dependencies>
     <dependency>
       <groupId>com.itextpdf</groupId>

commons/src/test/java/com/itextpdf/commons/utils/ExperimentalFeaturesTest.java

@@ -287,11 +287,11 @@ public void addFieldAppearanceToPage(PdfFormField field, PdfPage page) {
     }
 
     /**
-     * Gets the high-level{@link PdfFormField form field}s as a {@link Map}.
+     * Gets root fields (i.e. direct children of Acroform dictionary).
      *
      * @return a map of field names and their associated {@link PdfFormField form field} objects
      */
-    public Map<String, PdfFormField> getDirectFormFields() {
+    public Map<String, PdfFormField> getRootFormFields() {
         if (fields.size() == 0) {
             fields = populateFormFieldsMap();
         }
@@ -1088,7 +1088,7 @@ public void removeXfaForm() {
     }
 
     /**
-     * Put a key/value pair in the  dictionary and overwrites the previous value if it already exists.
+     * Put a key/value pair in the dictionary and overwrite previous value if it already exists.
      *
      * @param key   the key as pdf name
      * @param value the value as pdf object

forms/pom.xml

@@ -96,7 +96,7 @@ public void copy(PdfPage fromPage, PdfPage toPage) {
         if (fieldsFrom.size() <= 0) {
             return;
         }
-        Map<String, PdfFormField> fieldsTo = formTo.getDirectFormFields();
+        Map<String, PdfFormField> fieldsTo = formTo.getRootFormFields();
 
         List<PdfAnnotation> annots = toPage.getAnnotations();