overflow-scroll="true" not working on android

[tzaavi]

I'm setting the content directive to use the native scroll [overflow-scroll="true"] and it's not scrolling on android.

[mlynch]

Thanks for letting us know, I'll take a look and get that fixed! Which
Android device and version are you on?

On Fri, Nov 22, 2013 at 8:10 PM, tzaavi notifications@github.com wrote:

I'm setting the content directive to use the native scroll
[overflow-scroll="true"] and it's not scrolling on android.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/179
.

[tzaavi]

Samsung S4
Android version: 4.2.2

It looks like something prevent the drag event. If I remove the javascript reference and just use the css file and HTML it’s working fine.

[mlynch]

Hey @tzaavi it might be related to #181 which I just fixed. Would you mind trying a recent release or master pull to see if that fixes it? Thanks!

[tzaavi]

I tested it with the latest from master and it’s still not working.

[mlynch]

Okay, thanks for doing that. I will take a look here and see what might be
causing it. I'm fixing a few other Android related things right now anyways.

On Sat, Nov 23, 2013 at 9:19 AM, tzaavi notifications@github.com wrote:

I tested it with the latest from master and it’s still not working.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/179#issuecomment-29134194
.

[tzaavi]

I did some testing and I narrow it down to gestures.

If I comment this line in js/utils/gestures.js (line 334) then it works

// trigger the handler
//handler.call(ionic.Gestures.detection, self.collectEventData(element, eventType, self.getTouchList(last_move_event, eventType), ev));

[mlynch]

Yep, looks like the gesture system is calling event.preventDefault inside of the Drag gesture handler. Basically, there is a drag gesture listened somewhere, and it's not checking if the element is the target. That needs to be fixed, seems like a bug from hammer.js which we use.

[tzaavi]

I tested the fix but it’s still not scrolling for me. Only work when scroll with 2 fingers.
Something is still blocking the drag event.

[mlynch]

Odd, it was just working for me. Reopening and taking another look.

[tzaavi]

I found a fix that work for me:

In ionicSlideMenu.js in sideMenuContent directive, instead of using drag event I’m using dragright and dragleft.

This solution not blocking the vertical scrolling while still let the use drag the menu left and right.
Another benefit is preventing unwanted menu slide while scrolling vertically.

replace

var dragGesture = Gesture.on('drag', dragFn, $element);

with

var dragRightGesture = Gesture.on('dragright', dragFn, $element);
var dragLeftGesture = Gesture.on('dragleft', dragFn, $element);

replace

Gesture.off(dragGesture, 'drag', dragFn);

with

Gesture.off(dragRightGesture, 'dragright', dragFn);
Gesture.off(dragLeftGesture, 'dragleft', dragFn);

[mlynch]

Thanks, I like that solution. Just tested it on the Nexus 4 and other devices and it works well now. Let me know if there are any other things that pop up.