Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 6e8bf49

Browse files
liamdebeasibrandyscarney
andauthoredApr 25, 2024
chore(theming): remove Sass default flags (#29401)
Issue number: N/A --------- ## What is the current behavior? Currently, every Sass variable in Ionic has the `!default` flag added to the end. From the [Sass variables documentation](https://sass-lang.com/documentation/variables/): > Normally when you assign a value to a variable, if that variable already had a value, its old value is overwritten. But if you’re writing a Sass library, you might want to allow your users to configure your library’s variables before you use them to generate CSS. > > To make this possible, Sass provides the `!default` flag. This assigns a value to a variable only if that variable isn’t defined or its value is [null](https://sass-lang.com/documentation/values/null). Otherwise, the existing value will be used. In past versions of Ionic Framework, developers wrote Sass variables to rebuild Ionic Framework using their own values. In the latest versions of Ionic Framework, this is not possible. ## What is the new behavior? Removes the `!default` flag from all Sass variables. ## Does this introduce a breaking change? - [ ] Yes - [x] No ------- Co-authored-by: brandyscarney <brandyscarney@users.noreply.github.com>
1 parent 0873dc2 commit 6e8bf49

File tree

127 files changed

+1301
-1301
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

127 files changed

+1301
-1301
lines changed
 

‎core/src/components/accordion/accordion.md.vars.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
// --------------------------------------------------
55

66
/// @prop - Border radius applied to the accordion
7-
$accordion-md-border-radius: 6px !default;
7+
$accordion-md-border-radius: 6px;
88

99
/// @prop - Box shadow of the accordion
10-
$accordion-md-box-shadow: 0px 3px 1px -2px rgba(0, 0, 0, 0.2), 0px 2px 2px 0px rgba(0, 0, 0, 0.14), 0px 1px 5px 0px rgba(0, 0, 0, 0.12) !default;
10+
$accordion-md-box-shadow: 0px 3px 1px -2px rgba(0, 0, 0, 0.2), 0px 2px 2px 0px rgba(0, 0, 0, 0.14), 0px 1px 5px 0px rgba(0, 0, 0, 0.12);
1111

1212
/// @prop - Margin of the expanded accordion
13-
$accordion-md-expanded-margin: 16px !default;
13+
$accordion-md-expanded-margin: 16px;

‎core/src/components/accordion/accordion.vars.scss

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,16 @@
44
// --------------------------------------------------
55

66
/// @prop - Background color of the accordion
7-
$accordion-background-color: var(--ion-background-color, #ffffff) !default;
7+
$accordion-background-color: var(--ion-background-color, #ffffff);
88

99
/// @prop - Duration of the accordion transition
10-
$accordion-transition-duration: 300ms !default;
10+
$accordion-transition-duration: 300ms;
1111

1212
/// @prop - Timing function of the accordion transition
13-
$accordion-transition-easing: cubic-bezier(0.25, 0.8, 0.5, 1) !default;
13+
$accordion-transition-easing: cubic-bezier(0.25, 0.8, 0.5, 1);
1414

1515
/// @prop - Opacity of the disabled accordion
16-
$accordion-disabled-opacity: 0.4 !default;
16+
$accordion-disabled-opacity: 0.4;
1717

1818
/// @prop - Margin of the inset accordion
19-
$accordion-inset-margin: 16px !default;
19+
$accordion-inset-margin: 16px;

0 commit comments

Comments
 (0)
Please sign in to comment.