Skip to content

Commit 14d3500

Browse files
BenOsodracthetaPC
andauthored
refactor(checkbox): use the new tokens (#29564)
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - updated ionic.checkbox.scss with ionic tokens and removed references to checkbox.scss partial - removed ionic.checkbox.vars.scss file - update snapshots resulted from slight differences due to the use of the updated tokens. - added theme-ionic html file to test basic use-cases with ionic theme. - border-radius now won't auto scale with `--size`. This was not possible to do using the gloabls tokens variables and the css calc(), as it was before. Besides, this is not something we are very interested to offer on Ionic theme. It should be on developer to also update the `--border-radius` variable if they want, after changing `--size`. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> --------- Co-authored-by: Maria Hutt <[email protected]>
1 parent 2441b8f commit 14d3500

File tree

118 files changed

+340
-78
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

118 files changed

+340
-78
lines changed

core/api.txt

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -516,37 +516,26 @@ ion-checkbox,prop,value,any,'on',false,false
516516
ion-checkbox,event,ionBlur,void,true
517517
ion-checkbox,event,ionChange,CheckboxChangeEventDetail<any>,true
518518
ion-checkbox,event,ionFocus,void,true
519-
ion-checkbox,css-prop,--border-color,ionic
520519
ion-checkbox,css-prop,--border-color,ios
521520
ion-checkbox,css-prop,--border-color,md
522-
ion-checkbox,css-prop,--border-color-checked,ionic
523521
ion-checkbox,css-prop,--border-color-checked,ios
524522
ion-checkbox,css-prop,--border-color-checked,md
525-
ion-checkbox,css-prop,--border-radius,ionic
526523
ion-checkbox,css-prop,--border-radius,ios
527524
ion-checkbox,css-prop,--border-radius,md
528-
ion-checkbox,css-prop,--border-style,ionic
529525
ion-checkbox,css-prop,--border-style,ios
530526
ion-checkbox,css-prop,--border-style,md
531-
ion-checkbox,css-prop,--border-width,ionic
532527
ion-checkbox,css-prop,--border-width,ios
533528
ion-checkbox,css-prop,--border-width,md
534-
ion-checkbox,css-prop,--checkbox-background,ionic
535529
ion-checkbox,css-prop,--checkbox-background,ios
536530
ion-checkbox,css-prop,--checkbox-background,md
537-
ion-checkbox,css-prop,--checkbox-background-checked,ionic
538531
ion-checkbox,css-prop,--checkbox-background-checked,ios
539532
ion-checkbox,css-prop,--checkbox-background-checked,md
540-
ion-checkbox,css-prop,--checkmark-color,ionic
541533
ion-checkbox,css-prop,--checkmark-color,ios
542534
ion-checkbox,css-prop,--checkmark-color,md
543-
ion-checkbox,css-prop,--checkmark-width,ionic
544535
ion-checkbox,css-prop,--checkmark-width,ios
545536
ion-checkbox,css-prop,--checkmark-width,md
546-
ion-checkbox,css-prop,--size,ionic
547537
ion-checkbox,css-prop,--size,ios
548538
ion-checkbox,css-prop,--size,md
549-
ion-checkbox,css-prop,--transition,ionic
550539
ion-checkbox,css-prop,--transition,ios
551540
ion-checkbox,css-prop,--transition,md
552541
ion-checkbox,part,container

0 commit comments

Comments
 (0)