Skip to content

Commit 02f3ad0

Browse files
authored
refactor(button): use the new tokens (#29561)
Issue number: Internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - On ionic.button.scss all dependencies to button.scss were removed, to avoid the old native theme values being mixed on the new ionic theme button. - ionic.button.vars.scss partial was removed - All values were changed to use tokens. - Updated snapshots that bring slight differences due to now we are totally using the ionic theme tokens. - Tests with colors where the ionic button was being added also now have differences, as the current ion-colors aren't affecting the ionic theme button. This is expected, as the ionic theme should only work with the colors from the new Design System, which is something being tacked on this [PR](#29557). in the future, we should remove the ionic button from these color ctests and create new ones that add the new set of colors to the ionic button. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. -->
1 parent f60a3f2 commit 02f3ad0

File tree

69 files changed

+266
-198
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

69 files changed

+266
-198
lines changed

core/api.txt

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -398,73 +398,50 @@ ion-button,prop,theme,"ios" | "md" | "ionic",undefined,false,false
398398
ion-button,prop,type,"button" | "reset" | "submit",'button',false,false
399399
ion-button,event,ionBlur,void,true
400400
ion-button,event,ionFocus,void,true
401-
ion-button,css-prop,--background,ionic
402401
ion-button,css-prop,--background,ios
403402
ion-button,css-prop,--background,md
404-
ion-button,css-prop,--background-activated,ionic
405403
ion-button,css-prop,--background-activated,ios
406404
ion-button,css-prop,--background-activated,md
407-
ion-button,css-prop,--background-activated-opacity,ionic
408405
ion-button,css-prop,--background-activated-opacity,ios
409406
ion-button,css-prop,--background-activated-opacity,md
410-
ion-button,css-prop,--background-focused,ionic
411407
ion-button,css-prop,--background-focused,ios
412408
ion-button,css-prop,--background-focused,md
413-
ion-button,css-prop,--background-focused-opacity,ionic
414409
ion-button,css-prop,--background-focused-opacity,ios
415410
ion-button,css-prop,--background-focused-opacity,md
416-
ion-button,css-prop,--background-hover,ionic
417411
ion-button,css-prop,--background-hover,ios
418412
ion-button,css-prop,--background-hover,md
419-
ion-button,css-prop,--background-hover-opacity,ionic
420413
ion-button,css-prop,--background-hover-opacity,ios
421414
ion-button,css-prop,--background-hover-opacity,md
422-
ion-button,css-prop,--border-color,ionic
423415
ion-button,css-prop,--border-color,ios
424416
ion-button,css-prop,--border-color,md
425-
ion-button,css-prop,--border-radius,ionic
426417
ion-button,css-prop,--border-radius,ios
427418
ion-button,css-prop,--border-radius,md
428-
ion-button,css-prop,--border-style,ionic
429419
ion-button,css-prop,--border-style,ios
430420
ion-button,css-prop,--border-style,md
431-
ion-button,css-prop,--border-width,ionic
432421
ion-button,css-prop,--border-width,ios
433422
ion-button,css-prop,--border-width,md
434-
ion-button,css-prop,--box-shadow,ionic
435423
ion-button,css-prop,--box-shadow,ios
436424
ion-button,css-prop,--box-shadow,md
437-
ion-button,css-prop,--color,ionic
438425
ion-button,css-prop,--color,ios
439426
ion-button,css-prop,--color,md
440-
ion-button,css-prop,--color-activated,ionic
441427
ion-button,css-prop,--color-activated,ios
442428
ion-button,css-prop,--color-activated,md
443-
ion-button,css-prop,--color-focused,ionic
444429
ion-button,css-prop,--color-focused,ios
445430
ion-button,css-prop,--color-focused,md
446-
ion-button,css-prop,--color-hover,ionic
447431
ion-button,css-prop,--color-hover,ios
448432
ion-button,css-prop,--color-hover,md
449-
ion-button,css-prop,--opacity,ionic
450433
ion-button,css-prop,--opacity,ios
451434
ion-button,css-prop,--opacity,md
452-
ion-button,css-prop,--padding-bottom,ionic
453435
ion-button,css-prop,--padding-bottom,ios
454436
ion-button,css-prop,--padding-bottom,md
455-
ion-button,css-prop,--padding-end,ionic
456437
ion-button,css-prop,--padding-end,ios
457438
ion-button,css-prop,--padding-end,md
458-
ion-button,css-prop,--padding-start,ionic
459439
ion-button,css-prop,--padding-start,ios
460440
ion-button,css-prop,--padding-start,md
461-
ion-button,css-prop,--padding-top,ionic
462441
ion-button,css-prop,--padding-top,ios
463442
ion-button,css-prop,--padding-top,md
464-
ion-button,css-prop,--ripple-color,ionic
465443
ion-button,css-prop,--ripple-color,ios
466444
ion-button,css-prop,--ripple-color,md
467-
ion-button,css-prop,--transition,ionic
468445
ion-button,css-prop,--transition,ios
469446
ion-button,css-prop,--transition,md
470447
ion-button,part,native

0 commit comments

Comments
 (0)