Skip to content

Commit 0124f3b

Browse files
test(many): replace ionic buttons in e2e tests with native html buttons (#29422)
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? The `ion-button` component is used in several tests to navigate or show overlays. This causes screenshot diffs in unrelated tests any time the UI of the `ion-button` is updated. ## What is the new behavior? Removes the `ion-button` elements from unrelated tests. Did not remove the `ion-button`s from the following tests: - All `ion-button`s in an `ion-buttons` component - An `ion-button` inside of a menu - breadcrumbs/test/basic (uses a clear button in a list header, needs to be moved) - input/test/slot - item/test/buttons - item/test/colors - item/test/dividers - item/test/inputs - item/test/media - list-header/test/basic - ripple-effect/test/basic - router/test/basic - router/test/guards - router-outlet/test/basic - select/test/slot - textarea/test/slot Updates the icon/basic test to use the right icon names by comparing against the v3 names: https://ionicframework.com/docs/v3/ionicons/ ## Does this introduce a breaking change? - [ ] Yes - [x] No --------- Co-authored-by: ionitron <[email protected]>
1 parent ba5cebf commit 0124f3b

File tree

669 files changed

+1077
-1192
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

669 files changed

+1077
-1192
lines changed

core/scripts/testing/styles.css

Lines changed: 20 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/src/components/action-sheet/test/a11y/index.html

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@
1919
<main class="ion-padding">
2020
<h1>Action Sheet - A11y</h1>
2121

22-
<ion-button id="bothHeaders" onclick="presentBothHeaders()">Both Headers</ion-button>
23-
<ion-button id="subHeaderOnly" onclick="presentSubHeaderOnly()">Subheader Only</ion-button>
24-
<ion-button id="noHeaders" onclick="presentNoHeaders()">No Headers</ion-button>
25-
<ion-button id="customAria" onclick="presentCustomAria()">Custom Aria</ion-button>
26-
<ion-button id="ariaLabelButton" onclick="presentAriaLabelButton()">Aria Label Button</ion-button>
27-
<ion-button id="ariaLabelCancelButton" onclick="presentAriaLabelCancelButton()"
28-
>Aria Label Cancel Button</ion-button
29-
>
22+
<button class="expand" id="bothHeaders" onclick="presentBothHeaders()">Both Headers</button>
23+
<button class="expand" id="subHeaderOnly" onclick="presentSubHeaderOnly()">Subheader Only</button>
24+
<button class="expand" id="noHeaders" onclick="presentNoHeaders()">No Headers</button>
25+
<button class="expand" id="customAria" onclick="presentCustomAria()">Custom Aria</button>
26+
<button class="expand" id="ariaLabelButton" onclick="presentAriaLabelButton()">Aria Label Button</button>
27+
<button class="expand" id="ariaLabelCancelButton" onclick="presentAriaLabelCancelButton()">
28+
Aria Label Cancel Button
29+
</button>
3030
</main>
3131

3232
<script>

0 commit comments

Comments
 (0)