Skip to content

Commit e11ad4e

Browse files
[NFC][SYCL] Auto-deduce return type for device_impl::get_info_impl* (#18446)
#18425 has ensured that current manually specified return type and the auto-deduced one are the same.
1 parent 4b7a7f9 commit e11ad4e

File tree

2 files changed

+186
-254
lines changed

2 files changed

+186
-254
lines changed

sycl/source/detail/device_impl.cpp

Lines changed: 28 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -28,23 +28,21 @@ device_impl::device_impl(ur_device_handle_t Device, platform_impl &Platform,
2828
const AdapterPtr &Adapter = Platform.getAdapter();
2929

3030
// TODO catch an exception and put it to list of asynchronous exceptions
31-
MType = get_info_impl<ur_device_type_t, UR_DEVICE_INFO_TYPE>();
31+
MType = get_info_impl<UR_DEVICE_INFO_TYPE>();
3232

3333
// No need to set MRootDevice when MAlwaysRootDevice is true
3434
// TODO: Is get_info aligned with this?
3535
if (!Platform.MAlwaysRootDevice) {
3636
// TODO catch an exception and put it to list of asynchronous exceptions
37-
MRootDevice =
38-
get_info_impl<ur_device_handle_t, UR_DEVICE_INFO_PARENT_DEVICE>();
37+
MRootDevice = get_info_impl<UR_DEVICE_INFO_PARENT_DEVICE>();
3938
}
4039

4140
// TODO catch an exception and put it to list of asynchronous exceptions
4241
// Interoperability Constructor already calls DeviceRetain in
4342
// urDeviceCreateWithNativeHandle.
4443
Adapter->call<UrApiKind::urDeviceRetain>(MDevice);
4544

46-
MUseNativeAssert =
47-
get_info_impl<ur_bool_t, UR_DEVICE_INFO_USE_NATIVE_ASSERT>();
45+
MUseNativeAssert = get_info_impl<UR_DEVICE_INFO_USE_NATIVE_ASSERT>();
4846
}
4947

5048
device_impl::~device_impl() {
@@ -119,8 +117,7 @@ device_impl::get_backend_info<info::device::backend_version>() const {
119117
#endif
120118

121119
bool device_impl::has_extension(const std::string &ExtensionName) const {
122-
std::string AllExtensionNames =
123-
get_info_impl<std::string, UR_DEVICE_INFO_EXTENSIONS>();
120+
std::string AllExtensionNames = get_info_impl<UR_DEVICE_INFO_EXTENSIONS>();
124121

125122
return (AllExtensionNames.find(ExtensionName) != std::string::npos);
126123
}
@@ -370,14 +367,12 @@ bool device_impl::has(aspect Aspect) const {
370367
case aspect::ext_oneapi_cuda_cluster_group:
371368
return get_info<info::device::ext_oneapi_cuda_cluster_group>();
372369
case aspect::usm_atomic_host_allocations:
373-
return (get_info_impl<ur_device_usm_access_capability_flags_t,
374-
UR_DEVICE_INFO_USM_HOST_SUPPORT>() &
370+
return (get_info_impl<UR_DEVICE_INFO_USM_HOST_SUPPORT>() &
375371
UR_DEVICE_USM_ACCESS_CAPABILITY_FLAG_ATOMIC_CONCURRENT_ACCESS);
376372
case aspect::usm_shared_allocations:
377373
return get_info<info::device::usm_shared_allocations>();
378374
case aspect::usm_atomic_shared_allocations:
379-
return (get_info_impl<ur_device_usm_access_capability_flags_t,
380-
UR_DEVICE_INFO_USM_SINGLE_SHARED_SUPPORT>() &
375+
return (get_info_impl<UR_DEVICE_INFO_USM_SINGLE_SHARED_SUPPORT>() &
381376
UR_DEVICE_USM_ACCESS_CAPABILITY_FLAG_ATOMIC_CONCURRENT_ACCESS);
382377
case aspect::usm_restricted_shared_allocations:
383378
return get_info<info::device::usm_restricted_shared_allocations>();
@@ -422,129 +417,113 @@ bool device_impl::has(aspect Aspect) const {
422417
case aspect::ext_oneapi_native_assert:
423418
return useNativeAssert();
424419
case aspect::ext_oneapi_cuda_async_barrier: {
425-
return get_info_impl_nocheck<ur_bool_t, UR_DEVICE_INFO_ASYNC_BARRIER>()
426-
.value_or(0);
420+
return get_info_impl_nocheck<UR_DEVICE_INFO_ASYNC_BARRIER>().value_or(0);
427421
}
428422
case aspect::ext_intel_legacy_image: {
429-
return get_info_impl_nocheck<ur_bool_t, UR_DEVICE_INFO_IMAGE_SUPPORT>()
430-
.value_or(0);
423+
return get_info_impl_nocheck<UR_DEVICE_INFO_IMAGE_SUPPORT>().value_or(0);
431424
}
432425
case aspect::ext_oneapi_bindless_images: {
433-
return get_info_impl_nocheck<ur_bool_t,
434-
UR_DEVICE_INFO_BINDLESS_IMAGES_SUPPORT_EXP>()
426+
return get_info_impl_nocheck<UR_DEVICE_INFO_BINDLESS_IMAGES_SUPPORT_EXP>()
435427
.value_or(0);
436428
}
437429
case aspect::ext_oneapi_bindless_images_shared_usm: {
438430
return get_info_impl_nocheck<
439-
ur_bool_t,
440431
UR_DEVICE_INFO_BINDLESS_IMAGES_SHARED_USM_SUPPORT_EXP>()
441432
.value_or(0);
442433
}
443434
case aspect::ext_oneapi_bindless_images_1d_usm: {
444435
return get_info_impl_nocheck<
445-
ur_bool_t, UR_DEVICE_INFO_BINDLESS_IMAGES_1D_USM_SUPPORT_EXP>()
436+
UR_DEVICE_INFO_BINDLESS_IMAGES_1D_USM_SUPPORT_EXP>()
446437
.value_or(0);
447438
}
448439
case aspect::ext_oneapi_bindless_images_2d_usm: {
449440
return get_info_impl_nocheck<
450-
ur_bool_t, UR_DEVICE_INFO_BINDLESS_IMAGES_2D_USM_SUPPORT_EXP>()
441+
UR_DEVICE_INFO_BINDLESS_IMAGES_2D_USM_SUPPORT_EXP>()
451442
.value_or(0);
452443
}
453444
case aspect::ext_oneapi_external_memory_import: {
454445
return get_info_impl_nocheck<
455-
ur_bool_t, UR_DEVICE_INFO_EXTERNAL_MEMORY_IMPORT_SUPPORT_EXP>()
446+
UR_DEVICE_INFO_EXTERNAL_MEMORY_IMPORT_SUPPORT_EXP>()
456447
.value_or(0);
457448
}
458449
case aspect::ext_oneapi_external_semaphore_import: {
459450
return get_info_impl_nocheck<
460-
ur_bool_t,
461451
UR_DEVICE_INFO_EXTERNAL_SEMAPHORE_IMPORT_SUPPORT_EXP>()
462452
.value_or(0);
463453
}
464454
case aspect::ext_oneapi_mipmap: {
465-
return get_info_impl_nocheck<ur_bool_t, UR_DEVICE_INFO_MIPMAP_SUPPORT_EXP>()
466-
.value_or(0);
455+
return get_info_impl_nocheck<UR_DEVICE_INFO_MIPMAP_SUPPORT_EXP>().value_or(
456+
0);
467457
}
468458
case aspect::ext_oneapi_mipmap_anisotropy: {
469-
return get_info_impl_nocheck<ur_bool_t,
470-
UR_DEVICE_INFO_MIPMAP_ANISOTROPY_SUPPORT_EXP>()
459+
return get_info_impl_nocheck<UR_DEVICE_INFO_MIPMAP_ANISOTROPY_SUPPORT_EXP>()
471460
.value_or(0);
472461
}
473462
case aspect::ext_oneapi_mipmap_level_reference: {
474463
return get_info_impl_nocheck<
475-
ur_bool_t, UR_DEVICE_INFO_MIPMAP_LEVEL_REFERENCE_SUPPORT_EXP>()
464+
UR_DEVICE_INFO_MIPMAP_LEVEL_REFERENCE_SUPPORT_EXP>()
476465
.value_or(0);
477466
}
478467
case aspect::ext_oneapi_bindless_sampled_image_fetch_1d_usm: {
479468
return get_info_impl_nocheck<
480-
ur_bool_t,
481469
UR_DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_1D_USM_SUPPORT_EXP>()
482470
.value_or(0);
483471
}
484472
case aspect::ext_oneapi_bindless_sampled_image_fetch_1d: {
485473
return get_info_impl_nocheck<
486-
ur_bool_t,
487474
UR_DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_1D_SUPPORT_EXP>()
488475
.value_or(0);
489476
}
490477
case aspect::ext_oneapi_bindless_sampled_image_fetch_2d_usm: {
491478
return get_info_impl_nocheck<
492-
ur_bool_t,
493479
UR_DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_2D_USM_SUPPORT_EXP>()
494480
.value_or(0);
495481
}
496482
case aspect::ext_oneapi_bindless_sampled_image_fetch_2d: {
497483
return get_info_impl_nocheck<
498-
ur_bool_t,
499484
UR_DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_2D_SUPPORT_EXP>()
500485
.value_or(0);
501486
}
502487
case aspect::ext_oneapi_bindless_sampled_image_fetch_3d: {
503488
return get_info_impl_nocheck<
504-
ur_bool_t,
505489
UR_DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_3D_SUPPORT_EXP>()
506490
.value_or(0);
507491
}
508492
case aspect::ext_oneapi_bindless_images_gather: {
509493
return get_info_impl_nocheck<
510-
ur_bool_t, UR_DEVICE_INFO_BINDLESS_IMAGES_GATHER_SUPPORT_EXP>()
494+
UR_DEVICE_INFO_BINDLESS_IMAGES_GATHER_SUPPORT_EXP>()
511495
.value_or(0);
512496
}
513497
case aspect::ext_oneapi_cubemap: {
514-
return get_info_impl_nocheck<ur_bool_t,
515-
UR_DEVICE_INFO_CUBEMAP_SUPPORT_EXP>()
516-
.value_or(0);
498+
return get_info_impl_nocheck<UR_DEVICE_INFO_CUBEMAP_SUPPORT_EXP>().value_or(
499+
0);
517500
}
518501
case aspect::ext_oneapi_cubemap_seamless_filtering: {
519502
return get_info_impl_nocheck<
520-
ur_bool_t,
521503
UR_DEVICE_INFO_CUBEMAP_SEAMLESS_FILTERING_SUPPORT_EXP>()
522504
.value_or(0);
523505
}
524506
case aspect::ext_oneapi_image_array: {
525-
return get_info_impl_nocheck<ur_bool_t,
526-
UR_DEVICE_INFO_IMAGE_ARRAY_SUPPORT_EXP>()
507+
return get_info_impl_nocheck<UR_DEVICE_INFO_IMAGE_ARRAY_SUPPORT_EXP>()
527508
.value_or(0);
528509
}
529510
case aspect::ext_oneapi_unique_addressing_per_dim: {
530511
return get_info_impl_nocheck<
531-
ur_bool_t,
532512
UR_DEVICE_INFO_BINDLESS_UNIQUE_ADDRESSING_PER_DIM_SUPPORT_EXP>()
533513
.value_or(0);
534514
}
535515
case aspect::ext_oneapi_bindless_images_sample_1d_usm: {
536516
return get_info_impl_nocheck<
537-
ur_bool_t, UR_DEVICE_INFO_BINDLESS_SAMPLE_1D_USM_SUPPORT_EXP>()
517+
UR_DEVICE_INFO_BINDLESS_SAMPLE_1D_USM_SUPPORT_EXP>()
538518
.value_or(0);
539519
}
540520
case aspect::ext_oneapi_bindless_images_sample_2d_usm: {
541521
return get_info_impl_nocheck<
542-
ur_bool_t, UR_DEVICE_INFO_BINDLESS_SAMPLE_2D_USM_SUPPORT_EXP>()
522+
UR_DEVICE_INFO_BINDLESS_SAMPLE_2D_USM_SUPPORT_EXP>()
543523
.value_or(0);
544524
}
545525
case aspect::ext_intel_esimd: {
546-
return get_info_impl_nocheck<ur_bool_t, UR_DEVICE_INFO_ESIMD_SUPPORT>()
547-
.value_or(0);
526+
return get_info_impl_nocheck<UR_DEVICE_INFO_ESIMD_SUPPORT>().value_or(0);
548527
}
549528
case aspect::ext_oneapi_ballot_group:
550529
case aspect::ext_oneapi_fixed_size_group:
@@ -587,9 +566,8 @@ bool device_impl::has(aspect Aspect) const {
587566
return components.size() >= 2;
588567
}
589568
case aspect::ext_oneapi_is_component: {
590-
return get_info_impl_nocheck<ur_device_handle_t,
591-
UR_DEVICE_INFO_COMPOSITE_DEVICE>()
592-
.value_or(nullptr) != nullptr;
569+
return get_info_impl_nocheck<UR_DEVICE_INFO_COMPOSITE_DEVICE>().value_or(
570+
nullptr) != nullptr;
593571
}
594572
case aspect::ext_oneapi_graph: {
595573
ur_device_command_buffer_update_capability_flags_t UpdateCapabilities;
@@ -635,12 +613,11 @@ bool device_impl::has(aspect Aspect) const {
635613
}
636614
case aspect::ext_oneapi_queue_profiling_tag: {
637615
return get_info_impl_nocheck<
638-
ur_bool_t, UR_DEVICE_INFO_TIMESTAMP_RECORDING_SUPPORT_EXP>()
616+
UR_DEVICE_INFO_TIMESTAMP_RECORDING_SUPPORT_EXP>()
639617
.value_or(0);
640618
}
641619
case aspect::ext_oneapi_virtual_mem: {
642-
return get_info_impl_nocheck<ur_bool_t,
643-
UR_DEVICE_INFO_VIRTUAL_MEMORY_SUPPORT>()
620+
return get_info_impl_nocheck<UR_DEVICE_INFO_VIRTUAL_MEMORY_SUPPORT>()
644621
.value_or(0);
645622
}
646623
case aspect::ext_intel_fpga_task_sequence: {
@@ -664,7 +641,7 @@ bool device_impl::has(aspect Aspect) const {
664641
}
665642
case aspect::ext_oneapi_async_memory_alloc: {
666643
return get_info_impl_nocheck<
667-
ur_bool_t, UR_DEVICE_INFO_ASYNC_USM_ALLOCATIONS_SUPPORT_EXP>()
644+
UR_DEVICE_INFO_ASYNC_USM_ALLOCATIONS_SUPPORT_EXP>()
668645
.value_or(0);
669646
}
670647
}

0 commit comments

Comments
 (0)