Skip to content

Commit db27d38

Browse files
[NFC][SYCL] Minor perf fixes after #18767 (#18964)
Issues identification/suggested fixes by @Alexandr-Konovalov. This doesn't fix everything, but let's merge what we're sure about already.
1 parent 9f89530 commit db27d38

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

sycl/source/detail/event_impl.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ event_impl::event_impl(const QueueImplPtr &Queue)
192192
}
193193

194194
void event_impl::setQueue(queue_impl &Queue) {
195-
MQueue = Queue.shared_from_this();
195+
MQueue = Queue.weak_from_this();
196196
MIsProfilingEnabled = Queue.MIsProfilingEnabled;
197197

198198
// TODO After setting the queue, the event is no longer default
@@ -202,9 +202,9 @@ void event_impl::setQueue(queue_impl &Queue) {
202202
}
203203

204204
void event_impl::setSubmittedQueue(std::weak_ptr<queue_impl> SubmittedQueue) {
205-
MSubmittedQueue = SubmittedQueue;
205+
MSubmittedQueue = std::move(SubmittedQueue);
206206
if (MHostProfilingInfo) {
207-
if (auto QueuePtr = SubmittedQueue.lock()) {
207+
if (auto QueuePtr = MSubmittedQueue.lock()) {
208208
device_impl &Device = QueuePtr->getDeviceImpl();
209209
MHostProfilingInfo->setDevice(&Device);
210210
}

sycl/source/detail/event_impl.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ class event_impl {
235235
///
236236
/// @return
237237
void setWorkerQueue(std::weak_ptr<queue_impl> WorkerQueue) {
238-
MWorkerQueue = WorkerQueue;
238+
MWorkerQueue = std::move(WorkerQueue);
239239
};
240240

241241
/// Sets original queue used for submission.

0 commit comments

Comments
 (0)