Skip to content

Commit 0120a78

Browse files
authored
Increase tolerance for ground truth test (#157)
We have seen test failures on new systems with the difference consistently 8.
1 parent d76528e commit 0120a78

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

bindings/python/tests/test_common.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -215,12 +215,9 @@ def test_generate_test_dataset(self):
215215
k_smallest = np.argsort(dist_squared)[:, :k]
216216

217217
# Some ties may not be resolved correctly, so provide some wiggle room.
218-
# Older architectures with different distance implementations may resolve ties
218+
# Architectures with different distance implementations may resolve ties
219219
# differently.
220-
#
221-
# Set max-ties to 6 to handle these older architectures as well (on newer
222-
# architecture, it's generally 4).
223-
max_ties = 6
220+
max_ties = 8
224221
expected_equal_lower = groundtruth.size - max_ties
225222
actually_equal = np.count_nonzero(k_smallest == groundtruth)
226223

0 commit comments

Comments
 (0)