Skip to content

Commit 98807e3

Browse files
remove TODO
1 parent c5f6b81 commit 98807e3

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

active-record/src/main/java/com/iluwatar/activerecord/base/RecordBase.java

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,6 @@
1616
import lombok.RequiredArgsConstructor;
1717

1818
/**
19-
* TODO: Think on potential simplification - perhaps for this use case we could just KISS by moving all the logic into the domain model itself.
20-
* Hence at the same time each domain model will contain lots of boilerplate code.
21-
* Let's think - Ruby has the record base parent object which encapsulates all the active record pattern logic.
22-
* Therefore this one "the parent" hsa all the public API.
23-
* This one adheres to the same pattern at the moment by implementing all the boilerplate persistence logic.
24-
* Potentially two course of actions at this stage:
25-
* 1. Just KISS it - and move all the persistence logic into the domain models themselves and just copy-paste, copy-paste, copy-paste, copy-...
26-
* 2. Finish this abstract class and make things smoooth
2719
* An active record base supposed to hold all the necessary active record pattern logic.
2820
*
2921
* <p>This is the base class which is supposed to be extended by all the domain models that are
@@ -34,7 +26,8 @@
3426
@RequiredArgsConstructor
3527
public abstract class RecordBase<T extends RecordBase<?>> {
3628

37-
private static final String EXCEPTION_MESSAGE = "Couldn't execute database query for the following domain model :";
29+
private static final String EXCEPTION_MESSAGE =
30+
"Couldn't execute database query for the following domain model :";
3831

3932
private static DataSource dataSource;
4033

0 commit comments

Comments
 (0)