Skip to content

Commit a6a96c0

Browse files
lesstifStyleCIBot
lesstif
and
StyleCIBot
authored
Apply fixes from StyleCI (lesstif#546)
[ci skip] [skip ci] Co-authored-by: StyleCI Bot <[email protected]>
1 parent 46b2040 commit a6a96c0

17 files changed

+28
-19
lines changed

‎src/Auth/AuthService.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ public function getSessionCookieValue()
8080
* @throws \Exception
8181
* @throws \JiraRestApi\JiraException
8282
*/
83-
public function __construct(ConfigurationInterface $configuration = null, LoggerInterface $logger = null, $path = './')
83+
public function __construct(?ConfigurationInterface $configuration = null, ?LoggerInterface $logger = null, $path = './')
8484
{
8585
parent::__construct($configuration, $logger, $path);
8686
$this->setAPIUri($this->auth_api_uri);

‎src/Board/BoardService.php

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class BoardService extends \JiraRestApi\JiraClient
1414

1515
private $agileVersion = '1.0';
1616

17-
public function __construct(ConfigurationInterface $configuration = null, LoggerInterface $logger = null, $path = './')
17+
public function __construct(?ConfigurationInterface $configuration = null, ?LoggerInterface $logger = null, $path = './')
1818
{
1919
parent::__construct($configuration, $logger, $path);
2020
$this->setAPIUri('/rest/agile/'.$this->agileVersion);
@@ -51,20 +51,22 @@ public function getBoardList($paramArray = []): ?\ArrayObject
5151
*
5252
* @param array $paramArray
5353
*
54-
* @return PaginatedResult|null array of Board class
55-
*@throws \JiraRestApi\JiraException
54+
* @throws \JiraRestApi\JiraException
5655
*
56+
* @return PaginatedResult|null array of Board class
5757
*/
5858
public function getBoards($paramArray = []): ?PaginatedResult
5959
{
6060
$json = $this->exec($this->uri.$this->toHttpQueryParameter($paramArray), null);
61+
6162
try {
6263
return $this->json_mapper->map(
6364
json_decode($json, false, 512, $this->getJsonOptions()),
6465
new PaginatedResult()
6566
);
6667
} catch (\JsonException $exception) {
6768
$this->log->error("Response cannot be decoded from json\nException: {$exception->getMessage()}");
69+
6870
return null;
6971
}
7072
}
@@ -165,6 +167,7 @@ public function getSprintsForBoard($boardId, $paramArray = []): ?PaginatedResult
165167
);
166168
} catch (\JsonException $exception) {
167169
$this->log->error("Response cannot be decoded from json\nException: {$exception->getMessage()}");
170+
168171
return null;
169172
}
170173
}

‎src/Board/PaginatedResult.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
namespace JiraRestApi\Board;
44

55
/**
6-
* Paginated Result object for BoardService
6+
* Paginated Result object for BoardService.
77
*/
88
class PaginatedResult
99
{

‎src/Configuration/ArrayConfiguration.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
/**
34
* Created by PhpStorm.
45
* User: keanor

‎src/Configuration/ConfigurationInterface.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
/**
34
* Created by PhpStorm.
45
* User: keanor

‎src/Epic/EpicService.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ class EpicService extends \JiraRestApi\JiraClient
1111
private $uri = '/epic';
1212
private $version = '1.0';
1313

14-
public function __construct(ConfigurationInterface $configuration = null, LoggerInterface $logger = null, $path = './')
14+
public function __construct(?ConfigurationInterface $configuration = null, ?LoggerInterface $logger = null, $path = './')
1515
{
1616
parent::__construct($configuration, $logger, $path);
1717
$this->setAPIUri('/rest/agile/'.$this->version);

‎src/Issue/AgileIssueService.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ class AgileIssueService extends \JiraRestApi\JiraClient
1111

1212
private $agileVersion = '1.0';
1313

14-
public function __construct(ConfigurationInterface $configuration = null, LoggerInterface $logger = null, $path = './')
14+
public function __construct(?ConfigurationInterface $configuration = null, ?LoggerInterface $logger = null, $path = './')
1515
{
1616
parent::__construct($configuration, $logger, $path);
1717
$this->setAPIUri('/rest/agile/'.$this->agileVersion);

‎src/Issue/IssueSearchResult.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
/**
34
* Created by PhpStorm.
45
* User: keanor

‎src/Issue/TimeTracking.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
/**
34
* Created by PhpStorm.
45
* User: keanor

‎src/JiraClient.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ class JiraClient
5959
*
6060
* @throws JiraException
6161
*/
62-
public function __construct(ConfigurationInterface $configuration = null, LoggerInterface $logger = null, string $path = './')
62+
public function __construct(?ConfigurationInterface $configuration = null, ?LoggerInterface $logger = null, string $path = './')
6363
{
6464
if ($configuration === null) {
6565
if (!file_exists($path.'.env')) {
@@ -188,7 +188,7 @@ protected function filterNullVariable(array $haystack): array
188188
*
189189
* @return string|bool
190190
*/
191-
public function exec(string $context, array|string $post_data = null, string $custom_request = null, string $cookieFile = null): string|bool
191+
public function exec(string $context, array|string|null $post_data = null, ?string $custom_request = null, ?string $cookieFile = null): string|bool
192192
{
193193
$url = $this->createUrlByContext($context);
194194

@@ -441,7 +441,7 @@ protected function createUrlByContext(string $context): string
441441
/**
442442
* Add authorize to curl request.
443443
*/
444-
protected function authorization(\CurlHandle $ch, array &$curl_http_headers, string $cookieFile = null): void
444+
protected function authorization(\CurlHandle $ch, array &$curl_http_headers, ?string $cookieFile = null): void
445445
{
446446
// use cookie
447447
if ($this->getConfiguration()->isCookieAuthorizationEnabled()) {
@@ -516,7 +516,7 @@ public function toHttpQueryParameter(array $paramArray, bool $dropNullKey = true
516516
/**
517517
* download and save into outDir.
518518
*/
519-
public function download(string $url, string $outDir, string $file, string $cookieFile = null): mixed
519+
public function download(string $url, string $outDir, string $file, ?string $cookieFile = null): mixed
520520
{
521521
$curl_http_header = [
522522
'Accept: */*',

‎src/JiraException.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
/**
34
* Created by PhpStorm.
45
* User: keanor
@@ -23,7 +24,7 @@ class JiraException extends \Exception
2324
/**
2425
* Create a new Jira exception instance.
2526
*/
26-
public function __construct(?string $message = null, int $code = 0, \Throwable $previous = null, string $response = null)
27+
public function __construct(?string $message = null, int $code = 0, ?\Throwable $previous = null, ?string $response = null)
2728
{
2829
parent::__construct($message, $code, $previous);
2930

‎src/RapidCharts/ScopeChangeBurnDownChartService.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class ScopeChangeBurnDownChartService extends \JiraRestApi\JiraClient
1212

1313
private $uri = '/rapid/charts/scopechangeburndownchart';
1414

15-
public function __construct(ConfigurationInterface $configuration = null, LoggerInterface $logger = null, $path = './')
15+
public function __construct(?ConfigurationInterface $configuration = null, ?LoggerInterface $logger = null, $path = './')
1616
{
1717
parent::__construct($configuration, $logger, $path);
1818
$this->setupAPIUri();

‎src/Request/RequestService.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class RequestService extends \JiraRestApi\JiraClient
2323
* @throws JiraException
2424
* @throws \Exception
2525
*/
26-
public function __construct(ConfigurationInterface $configuration = null, LoggerInterface $logger = null, $path = './')
26+
public function __construct(?ConfigurationInterface $configuration = null, ?LoggerInterface $logger = null, $path = './')
2727
{
2828
parent::__construct($configuration, $logger, $path);
2929
$this->setupAPIUri();

‎src/ServiceDesk/Request/RequestService.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public function getRequestFromJSON(object $jsonData): Request
6565
*
6666
* @see https://docs.atlassian.com/jira-servicedesk/REST/3.6.2/#servicedeskapi/request-getCustomerRequestByIdOrKey
6767
*/
68-
public function get(string $issueId, array $expandParameters = [], Request $request = null): Request
68+
public function get(string $issueId, array $expandParameters = [], ?Request $request = null): Request
6969
{
7070
$request = ($request) ?: new Request();
7171

@@ -88,7 +88,7 @@ public function get(string $issueId, array $expandParameters = [], Request $requ
8888
*
8989
* @see https://docs.atlassian.com/jira-servicedesk/REST/3.6.2/#servicedeskapi/request-getMyCustomerRequests
9090
*/
91-
public function getRequestsByCustomer(Customer $customer, array $searchParameters, int $serviceDeskId = null): array
91+
public function getRequestsByCustomer(Customer $customer, array $searchParameters, ?int $serviceDeskId = null): array
9292
{
9393
$defaultSearchParameters = [
9494
'requestOwnership' => 'OWNED_REQUESTS',

‎src/ServiceDesk/ServiceDeskClient.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
class ServiceDeskClient extends JiraClient
1313
{
1414
public function __construct(
15-
ConfigurationInterface $configuration = null,
16-
LoggerInterface $logger = null,
15+
?ConfigurationInterface $configuration = null,
16+
?LoggerInterface $logger = null,
1717
string $path = './'
1818
) {
1919
parent::__construct($configuration, $logger, $path);

‎src/Sprint/SprintSearchResult.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
/**
34
* Created by PhpStorm.
45
* User: keanor

‎src/Sprint/SprintService.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class SprintService extends JiraClient
1414
{
1515
private $uri = '/sprint';
1616

17-
public function __construct(ConfigurationInterface $configuration = null, LoggerInterface $logger = null, $path = './')
17+
public function __construct(?ConfigurationInterface $configuration = null, ?LoggerInterface $logger = null, $path = './')
1818
{
1919
parent::__construct($configuration, $logger, $path);
2020
$this->setAPIUri('/rest/agile/1.0');

0 commit comments

Comments
 (0)