Skip to content

Close listening socket on graceful shutdown #2342

@stepancheg

Description

@stepancheg

Feature Request

Crates

tonic

Motivation

  • listening socket will never be served, so holding it is pointless
  • but it is helpful for testing behavior like reconnecting on server restart

Proposal

In the middle of here:

}
if graceful {

add

drop(incoming);

Alternatives

Use your own incoming and connect it to the same signal.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions