Skip to content

Commit db90a01

Browse files
committed
Compare semver over .equals comparisons
1 parent 76acfcd commit db90a01

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@
22
*.iml
33
target/
44
dependency-reduced-pom.xml
5-
pom.xml.versionsBackup
5+
pom.xml.versionsBackup
6+
/src/test/

pom.xml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@
113113
</build>
114114

115115
<dependencies>
116+
<!-- To read and use the Spigot API -->
116117
<dependency>
117118
<groupId>com.googlecode.json-simple</groupId>
118119
<artifactId>json-simple</artifactId>
@@ -125,6 +126,13 @@
125126
</exclusion>
126127
</exclusions>
127128
</dependency>
129+
130+
<!-- To compare semver -->
131+
<dependency>
132+
<groupId>org.apache.maven</groupId>
133+
<artifactId>maven-artifact</artifactId>
134+
<version>3.6.3</version>
135+
</dependency>
128136
</dependencies>
129137

130138
</project>

src/main/java/dev/hypera/updatelib/internal/tasks/UpdateChecker.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package dev.hypera.updatelib.internal.tasks;
1818

1919
import dev.hypera.updatelib.internal.UpdateResponse;
20+
import org.apache.maven.artifact.versioning.ComparableVersion;
2021
import org.json.simple.JSONObject;
2122
import org.json.simple.JSONValue;
2223

@@ -53,7 +54,7 @@ public UpdateResponse check(long resourceId, String currentVersion, int timeout)
5354

5455
if(null == spigotVersion)
5556
return null;
56-
return new UpdateResponse(!currentVersion.equalsIgnoreCase(spigotVersion), currentVersion, spigotVersion);
57+
return new UpdateResponse(new ComparableVersion(currentVersion).compareTo(new ComparableVersion(spigotVersion)) < 0, currentVersion, spigotVersion);
5758
}
5859

5960
/**

0 commit comments

Comments
 (0)