Skip to content

Cargo.lock needs to be updated in version 1.1.2 #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lahwaacz opened this issue May 17, 2025 · 2 comments
Open

Cargo.lock needs to be updated in version 1.1.2 #342

lahwaacz opened this issue May 17, 2025 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@lahwaacz
Copy link

Hi, building hf_xet 1.1.2 from source with maturin build --locked --release fails:

    Updating crates.io index
error: the lock file /build/xet-core/src/xet-core-1.1.2/hf_xet/Cargo.lock needs to be updated but --locked was passed to prevent this
If you want to try to generate the lock file without accessing the network, remove the --locked flag and use --offline instead.
💥 maturin failed
  Caused by: Cargo metadata failed. Does your crate compile with `cargo build`?
  Caused by: `cargo metadata` exited with an error:
@rajatarya rajatarya self-assigned this May 19, 2025
@rajatarya rajatarya added the bug Something isn't working label May 19, 2025
@rajatarya
Copy link
Collaborator

Good catch @lahwaacz ! We will clean this up in our next release. I updated the Cargo.toml for 1.1.2 through GitHub web interface without running maturin locally, so Cargo.lock wasn't updated. I will update our deployment process to make sure Cargo.lock and Cargo.toml are updated for each release.

Can you tell me more about the use case which leads to building hf-xet from source? Is there a platform you use that isn't supported from the binary Python whls?

@lahwaacz
Copy link
Author

We build a package for Arch Linux: https://archlinux.org/packages/extra/x86_64/python-hf-xet/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants