App is crashing when the page is refreshed several times

[jsonmaur]

I have a simple connect app setup with a proxy that points to a remote location (off server), and when I refresh the page a bunch of times really fast, I get this error: { [Error: socket hang up] code: 'ECONNRESET' }. If it isn't caught with proxy.on('error'), then the entire app will crash. I know this is a weird use case, and it may not be a bug at all. If so, I would appreciate it if someone could help me understand this error. According to google, the error means "the other side of the TCP conversation abruptly closed its end of the connection". I'm not sure how this relates to the proxy. I just want to make sure it won't show up if my proxy starts getting thousands of requests per second. Here is the code for my sample app:

var connect = require('connect')
var httpProxy = require('http-proxy')

var app = connect()
var proxy = httpProxy.createProxyServer()

proxy.on('error', function(e) {
  console.error(e) // this is where the error is thrown
})

app.use(function(req, res, next) {
  req.headers.host = HOST // to change the host header
  next()
})

app.use(function(req, res) {
  proxy.web(req, res, {target: REMOTE_HOST})
})

app.listen(8080)

[jcrugzz]

@jdmaurer yea this is something id like to fix. The reason this happens in THIS specific case is because we don't disambiguate "client-side" request errors from "proxy" request errors. Errors that happen on the request that we receive as the proxy should be ignored because its something we have no control over. We cant even reply to it. This is a bug that needs to be fixed

[philcockfield]

I'm seeing this too. @jdmaurer why do you say this is a weird use-case? I have the same use-case, seems like the "meat and potatoes" of what a proxy would do?

@jcrugzz is this likely to be fixed soon? Thanks!

[jsonmaur]

@philcockfield I said it was a weird use-case cause I thought the error may be tied to a single client refreshing over and over causing the connection to not properly close--not because of many clients requesting at once. That seems to be the case.

[philcockfield]

👍

[mario-mui]

+1

[lemonCMS]

+1

[gabadi]

+1

[bubenshchykov]

+1

[jcrugzz]

@bubenshchykov can we confirm this still happens with 1.14.0?

[bubenshchykov]

[Error: socket hang up] code: 'ECONNRESET' - yes, it's on 1.14.0
I think I reproduced it by setting a low proxyTimeout (like 10ms) - just for a test
I will add a code snippet or spec later today :)

[bubenshchykov]

@jcrugzz this original issue (when client interrupts a request, eg by refreshing the page) is not reproducible on latest http-proxy - I think you can close this one! :)

PS I'm receiving {[Error: socket hang up] code: 'ECONNRESET' } when request times out - different story. Easy to reproduce by setting low proxyTimeout value. Dunno, is it by design? I would prefer some different error message for that, but that's not a big deal :)