Implement fallback for old MacOS versions

Author: BenBE

configure.ac

@@ -186,6 +186,25 @@ AC_CHECK_HEADERS([execinfo.h])
 
 if test "$my_htop_platform" = darwin; then
    AC_CHECK_HEADERS([mach/mach_time.h])
+   AC_CHECK_HEADERS([mach/thread_info.h])
+
+   AC_MSG_CHECKING(for thread_extended_info_data_t)
+   AC_COMPILE_IFELSE(
+      AC_LANG_PROGRAM(
+         [#include <mach/thread_info.h>],
+         [
+            thread_extended_info_data_t teid;
+            (void)teid;
+         ]
+      ),
+      [
+         AC_DEFINE([HAVE_THREAD_EXTENDED_INFO_DATA_T], 1, [Define if thread_extended_info_data_t is available from <mach/thread_info.h>])
+         AC_MSG_RESULT(yes)
+      ],
+      [
+         AC_MSG_RESULT(no)
+      ]
+   )
 fi
 
 # ----------------------------------------------------------------------

darwin/DarwinProcess.c

@@ -5,6 +5,8 @@ Released under the GNU GPLv2+, see the COPYING file
 in the source distribution for its full text.
 */
 
+#include "config.h" // IWYU pragma: keep
+
 #include "darwin/DarwinProcess.h"
 
 #include <libproc.h>
@@ -476,6 +478,7 @@ void DarwinProcess_scanThreads(DarwinProcess* dp, DarwinProcessTable* dpt) {
       tprocess->st_uid           = proc->st_uid;
       tprocess->user             = proc->user;
 
+#ifdef HAVE_THREAD_EXTENDED_INFO_DATA_T
       thread_extended_info_data_t extended_info;
       mach_msg_type_number_t extended_info_count = THREAD_EXTENDED_INFO_COUNT;
       ret = thread_info(thread_list[i], THREAD_EXTENDED_INFO, (thread_info_t) &extended_info, &extended_info_count);
@@ -495,9 +498,15 @@ void DarwinProcess_scanThreads(DarwinProcess* dp, DarwinProcessTable* dpt) {
          isProcessStuck |= true;
          tdproc->super.state = UNINTERRUPTIBLE_WAIT;
       }
+#endif
 
       // TODO: depend on setting
+#ifdef HAVE_THREAD_EXTENDED_INFO_DATA_T
       const char* name = extended_info.pth_name[0] != '\0' ? extended_info.pth_name : proc->procComm;
+#else
+      // Not provided in thread_basic_info_data_t; fall back to the process name
+      const char* name = proc->procComm;
+#endif
       Process_updateCmdline(tprocess, name, 0, name ? strlen(name) : 0);
 
       if (!preExisting)