Skip to content
This repository was archived by the owner on Nov 22, 2022. It is now read-only.

Commit ea68d04

Browse files
authored
(ci)Add npm script to run linter (#165)
* (ci)Add npm script to run linter This branch adds the ability to check linting by running `npm run lint`. The configuration is present at `.eslintrc` and focuses on the directories: src/ and test/ Future change: run it as a job with Travis CI. * (ci)add linting to travis * (core) undo changes for build/ file * (chore) change eslint to run with an allow list
1 parent 02281f2 commit ea68d04

File tree

8 files changed

+571
-14
lines changed

8 files changed

+571
-14
lines changed

.travis.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,12 @@ before_script:
77
- chmod +x ./cc-test-reporter
88
- ./cc-test-reporter before-build
99
after_script:
10-
- ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT
10+
- ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT
11+
jobs:
12+
include:
13+
- stage: test
14+
name: "Unit Tests"
15+
script: npm run test
16+
- stage: check
17+
name: "Linting"
18+
script: npm run lint

PULL_REQUEST_TEMPLATE.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,5 @@ TODO or DELETE
1010
- [ ] All existing tests passed.
1111
- [ ] I have added tests to cover my changes, of which pass.
1212
- [ ] I have [compared](https://github.com/hoverinc/ray-tracing-renderer/wiki/Contributing#comparing-changes) the render output of my branch to `master`.
13-
- [ ] My code has passed the ESLint configuration for this project.
1413
- [ ] My change requires modifications to the documentation.
1514
- [ ] I have updated the documentation accordingly.

0 commit comments

Comments
 (0)