Fix GritQL lint rules to work on empty files #641
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Genie <genie@cosine.sh>
Co-authored-by: Genie <genie@cosine.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue where GritQL lint rules do not function correctly on empty files. Specifically, it adds an integration test to ensure that the file predicate can match based solely on the file name, even when the file has no content.
The test simulates an empty file and verifies that the expected output is returned when the file name matches the specified pattern. This change ensures that the linting rules are robust and can handle edge cases involving empty files.
Original Task: gritql/1sqqkaq6azn1
Author: Morgante Pell