fix: Translation can get into untranslated state when it has value (tolgee#1714)

Author: JanCizmar

backend/app/src/main/kotlin/io/tolgee/api/v2/controllers/translation/TranslationsController.kt

@@ -34,7 +34,7 @@ import io.tolgee.model.Language
 import io.tolgee.model.Permission
 import io.tolgee.model.Screenshot
 import io.tolgee.model.enums.ApiScope
-import io.tolgee.model.enums.TranslationState
+import io.tolgee.model.enums.AssignableTranslationState
 import io.tolgee.model.key.Key
 import io.tolgee.model.translation.Translation
 import io.tolgee.model.views.KeyWithTranslationsView
@@ -217,11 +217,14 @@ When null, resulting file will be a flat key-value object.
   @AccessWithProjectPermission(permission = Permission.ProjectPermissionType.TRANSLATE)
   @Operation(summary = "Sets translation state")
   @RequestActivity(ActivityType.SET_TRANSLATION_STATE)
-  fun setTranslationState(@PathVariable translationId: Long, @PathVariable state: TranslationState): TranslationModel {
+  fun setTranslationState(
+    @PathVariable translationId: Long,
+    @PathVariable state: AssignableTranslationState
+  ): TranslationModel {
     val translation = translationService.get(translationId)
     translation.checkFromProject()
     securityService.checkLanguageTranslatePermission(translation)
-    return translationModelAssembler.toModel(translationService.setState(translation, state))
+    return translationModelAssembler.toModel(translationService.setState(translation, state.translationState))
   }
 
   @InitBinder("translationFilters")

backend/app/src/test/kotlin/io/tolgee/api/v2/controllers/translations/v2TranslationsController/TranslationsControllerModificationTest.kt

@@ -84,17 +84,26 @@ class TranslationsControllerModificationTest : ProjectAuthControllerTest("/v2/pr
   fun `sets translation state`() {
     saveTestData()
     val id = testData.aKeyGermanTranslation.id
-    performProjectAuthPut("/translations/$id/set-state/UNTRANSLATED", null).andIsOk
+    performProjectAuthPut("/translations/$id/set-state/TRANSLATED", null).andIsOk
       .andAssertThatJson {
-        node("state").isEqualTo("UNTRANSLATED")
+        node("state").isEqualTo("TRANSLATED")
         node("id").isValidId.satisfies { id ->
           id.toLong().let {
-            assertThat(translationService.find(it)?.state).isEqualTo(TranslationState.UNTRANSLATED)
+            assertThat(translationService.find(it)?.state).isEqualTo(TranslationState.TRANSLATED)
           }
         }
       }
   }
 
+  @ProjectJWTAuthTestMethod
+  @Test
+  fun `cannot set UNTRANSLATED when contains value`() {
+    saveTestData()
+    val id = testData.aKeyGermanTranslation.id
+    performProjectAuthPut("/translations/$id/set-state/UNTRANSLATED", null)
+      .andIsBadRequest
+  }
+
   @ProjectApiKeyAuthTestMethod(scopes = [ApiScope.TRANSLATIONS_VIEW])
   @Test
   fun `sets translations for existing key API key forbidden`() {

backend/data/src/main/kotlin/io/tolgee/model/enums/AssignableTranslationState.kt

@@ -0,0 +1,8 @@
+package io.tolgee.model.enums
+
+enum class AssignableTranslationState(
+  val translationState: TranslationState
+) {
+  TRANSLATED(TranslationState.TRANSLATED),
+  REVIEWED(TranslationState.REVIEWED),
+}

backend/data/src/main/kotlin/io/tolgee/model/translation/Translation.kt

@@ -34,7 +34,7 @@ import javax.validation.constraints.NotNull
   ]
 )
 @ActivityLoggedEntity
-@EntityListeners(Translation.Companion.UpdateStatsListener::class)
+@EntityListeners(Translation.Companion.UpdateStatsListener::class, Translation.Companion.StateListener::class)
 @ActivityEntityDescribingPaths(paths = ["key", "language"])
 class Translation(
   @Column(columnDefinition = "text")
@@ -93,10 +93,20 @@ class Translation(
     class UpdateStatsListener {
       @PrePersist
       @PreUpdate
-      fun preRemove(translation: Translation) {
+      fun preSave(translation: Translation) {
         translation.characterCount = TranslationStatsUtil.getCharacterCount(translation.text)
         translation.wordCount = TranslationStatsUtil.getWordCount(translation.text, translation.language.tag)
       }
     }
+
+    class StateListener {
+      @PrePersist
+      @PreUpdate
+      fun preSave(translation: Translation) {
+        if (!translation.text.isNullOrEmpty() && translation.state == TranslationState.UNTRANSLATED) {
+          translation.state = TranslationState.TRANSLATED
+        }
+      }
+    }
   }
 }