This should fix the same race condition in duplicate as 6c2a624 in create

The hashset is copied in toDto other we get
"Found shared references to a collection org.hibernate.HibernateException"
during the clone

Signed-off-by: HARPER Jon <[email protected]>

Author: jonenst

src/main/java/org/gridsuite/study/server/StudyService.java

@@ -580,7 +580,6 @@ private CreatedStudyBasicInfos insertStudy(UUID studyUuid, String userId, Networ
         return createdStudyBasicInfos;
     }
 
-    @Transactional
     public CreatedStudyBasicInfos insertDuplicatedStudy(BasicStudyInfos studyInfos, StudyEntity sourceStudy, LoadFlowParametersEntity newLoadFlowParameters, String userId, UUID clonedNetworkUuid) {
         Objects.requireNonNull(studyInfos.getId());
         Objects.requireNonNull(userId);
@@ -592,7 +591,7 @@ public CreatedStudyBasicInfos insertDuplicatedStudy(BasicStudyInfos studyInfos,
 
         UUID reportUuid = UUID.randomUUID();
         StudyEntity studyEntity = new StudyEntity(studyInfos.getId(), userId, LocalDateTime.now(ZoneOffset.UTC), clonedNetworkUuid, sourceStudy.getNetworkId(), sourceStudy.getCaseFormat(), sourceStudy.getCaseUuid(), sourceStudy.isCasePrivate(), sourceStudy.getLoadFlowProvider(), newLoadFlowParameters);
-        CreatedStudyBasicInfos createdStudyBasicInfos = StudyService.toCreatedStudyBasicInfos(insertDuplicatedStudy(studyEntity, sourceStudy.getId(), reportUuid));
+        CreatedStudyBasicInfos createdStudyBasicInfos = StudyService.toCreatedStudyBasicInfos(self.insertDuplicatedStudy(studyEntity, sourceStudy.getId(), reportUuid));
 
         studyInfosService.add(createdStudyBasicInfos);
         emitStudiesChanged(studyInfos.getId(), userId);

src/main/java/org/gridsuite/study/server/networkmodificationtree/NetworkModificationNodeInfoRepositoryProxy.java

@@ -68,7 +68,7 @@ public NetworkModificationNode toDto(NetworkModificationNodeInfoEntity node) {
         int ignoreSize = node.getModificationsToExclude().size(); // to load the lazy collection
         return completeNodeInfo(node, new NetworkModificationNode(node.getNetworkModificationId(),
             node.getVariantId(),
-            node.getModificationsToExclude(),
+            new HashSet<>(node.getModificationsToExclude()),
             node.getLoadFlowStatus(),
             StudyService.fromEntity(node.getLoadFlowResult()),
             node.getSecurityAnalysisResultUuid(),